Skip to content

New footer#1474

Merged
gemfarmer merged 2 commits intomasterfrom
bsh-footer
Jun 7, 2017
Merged

New footer#1474
gemfarmer merged 2 commits intomasterfrom
bsh-footer

Conversation

@gemfarmer
Copy link
Contributor

This PR updates the visual appearance of the footer. From issue 18F/identity-private#2073

Large screens:

screen shot 2017-06-05 at 5 05 12 pm

Small screens:

screen shot 2017-06-05 at 5 04 57 pm

@gemfarmer gemfarmer requested review from hursey013 and rtwell June 5, 2017 22:06
Copy link

@rtwell rtwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great—my only (very minor and essentially irrelevant) request would be to swap in an ampersand in "privacy & security"

@gemfarmer
Copy link
Contributor Author

@rtwell changes made.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this class exists already in Basscss.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the py0.center.caps from this since it's no longer stacked on mobile and caps is already listed once.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove .pt0.center

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to actually link to the GSA website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would probably be a good idea. It works well on the identity-site page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alt tags on both versions of GSA logo.

Copy link
Contributor

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things, otherwise lgtm!

@gemfarmer
Copy link
Contributor Author

Squashed and merging!

@gemfarmer gemfarmer merged commit 0878215 into master Jun 7, 2017
@gemfarmer gemfarmer deleted the bsh-footer branch June 7, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants