Update PSV to include issuer attributes#1472
Merged
zachmargolis merged 1 commit intomasterfrom Jun 5, 2017
Merged
Conversation
zachmargolis
commented
Jun 2, 2017
Contributor
Author
There was a problem hiding this comment.
I tried to use #dig but this is not a regular Hash, it is a Session object which doesn't implement #dig currently 😿
Contributor
There was a problem hiding this comment.
How about sp_session[:issuer]?
Contributor
Author
There was a problem hiding this comment.
I forgot we had that! Thanks, will use!
zachmargolis
force-pushed
the
margolis-update-psv
branch
2 times, most recently
from
e48d90a to
5a87e9a
Compare
zachmargolis
changed the title
zachmargolis
force-pushed
the
margolis-update-psv
branch
from
5a87e9a to
08cc33f
Compare
**Why**: So we can print the name of the SP and the URL to go to
zachmargolis
force-pushed
the
margolis-update-psv
branch
from
8807e70 to
a2a6876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So we can print the name of the SP and the URL to go to