Conversation
There was a problem hiding this comment.
is this a meaningful change from root_url to the interpolated string?
There was a problem hiding this comment.
For some reason, the test now goes to the domain based on domain_name instead of test.host, so we can't use the URL helpers anymore which apparently only work with test.host.
There was a problem hiding this comment.
Apparently this is due to returning a _url instead of _path in the decorated session. Switching to _path allows to use the URL helpers in the tests. I'll make the change.
There was a problem hiding this comment.
Would it be easier to just set properties on the underlying session hash than to stub this entire object?
There was a problem hiding this comment.
No, because the controller determines which URL to redirect to based on the decorated_session.
There was a problem hiding this comment.
Right, but we build a decorated session based on the values inside of the session? But it's not a huge deal
There was a problem hiding this comment.
Ah, yes. I see what you mean. I'll update.
|
Oh but looks like a spec is failing (possibly due to a copy change). LGTM % specs passing :) |
**Why**: If you came from an SP, canceling account creation should take you back to the branded start page.
2 participants
Why: If you came from an SP, canceling account creation should
take you back to the branded start page.