Skip to content

Toggle profile back to active following reactivate#1465

Merged
el-mapache merged 1 commit intomasterfrom
ab-reactivate-account
Jun 1, 2017
Merged

Toggle profile back to active following reactivate#1465
el-mapache merged 1 commit intomasterfrom
ab-reactivate-account

Conversation

@el-mapache
Copy link
Contributor

Why: The profile won't ever be put back into an active state
otherwise

**Why**: The profile won't ever be put back into an active state
otherwise
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add specs please!

@el-mapache
Copy link
Contributor Author

I thought testing that the account appears as 'verified' on the account page would be enough, what else would be useful to check?

@zachmargolis
Copy link
Contributor

Sorry I misread that spec! I was looking for a spec change for the form specifically that checks for the side effect like reactivate_account_form_spec.rb that checks for the specific property changing on the profile

@el-mapache el-mapache merged commit 05a5e33 into master Jun 1, 2017
@el-mapache el-mapache deleted the ab-reactivate-account branch June 1, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants