Conversation
**Why**: Before, we were excluding from POST controller action, which actually does not render a view. Instead, it redirects to various views depending on whether the confirmation token is valid or not. If it is invalid, we don't care about whether we show DAP or not because the session does not have trusted info. If the user is already confirmed, they will be logged in so DAP will not be included. So what we really care about is just the case when a user has a valid confirmation token. In that case, the user is redirected to `sign_up_enter_password_url` (see `process_valid_confirmation_token` method). Now, we are excluding DAP from that page. QA'd locally to make sure.
pkarman
approved these changes
Mar 29, 2017
Contributor
pkarman
left a comment
pkarman
left a comment
There was a problem hiding this comment.
code looks fine, though it would be nice if there was a way to feature-test the DAP code.
**Why**: To confirm that we are excluding from the pages that we think we are excluding from
Contributor
Author
Contributor
|
😻 |
pkarman
pushed a commit
that referenced
this pull request
Mar 30, 2017
**Why**: Before, we were excluding from POST controller action, which actually does not render a view. Instead, it redirects to various views depending on whether the confirmation token is valid or not. If it is invalid, we don't care about whether we show DAP or not because the session does not have trusted info. If the user is already confirmed, they will be logged in so DAP will not be included. So what we really care about is just the case when a user has a valid confirmation token. In that case, the user is redirected to `sign_up_enter_password_url` (see `process_valid_confirmation_token` method). Now, we are excluding DAP from that page.
pkarman
pushed a commit
that referenced
this pull request
Mar 31, 2017
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Before, we were excluding from POST controller action, which
actually does not render a view. Instead, it redirects to various views
depending on whether the confirmation token is valid or not. If it is
invalid, we don't care about whether we show DAP or not because the
session does not have trusted info. If the user is already confirmed,
they will be logged in so DAP will not be included. So what we really
care about is just the case when a user has a valid confirmation token.
In that case, the user is redirected to
sign_up_enter_password_url(see
process_valid_confirmation_tokenmethod). Now, we are excludingDAP from that page.
QA'd locally to make sure.