Add guard for if a sp does not exist in a SAML request#12556
Merged
Conversation
…cert serial if service provider exists
ajfarkas
approved these changes
Oct 3, 2025
Contributor
ajfarkas
left a comment
ajfarkas
left a comment
There was a problem hiding this comment.
Does what is says on the tin.
mitchellhenke
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new error has sprouted up since this PR adding user-facing errors to the SAML flow was deployed.
The specs did not catch it because it's fairly difficult to fake a bad SAML request; in order to get it to trigger, we need to mock out the
signed?method to returntrue, even though our fake SAML request is not actually signed.🛠 Summary of changes