[LG-16741] Fix last logged in on duplicate profile page#12555
Merged
joshuaalley25 merged 2 commits intomainfrom Oct 7, 2025
Merged
[LG-16741] Fix last logged in on duplicate profile page#12555joshuaalley25 merged 2 commits intomainfrom
joshuaalley25 merged 2 commits intomainfrom
Conversation
changelog: Bug Fixes, One Account, replace how we are displaying last login for duplicate accounts
jmdembe
reviewed
Oct 3, 2025
| :duplicate_profile_set, | ||
| profile_ids: [user.active_profile.id, profile2.id], | ||
| service_provider: 'test-sp', | ||
| service_provider: sp, |
Contributor
There was a problem hiding this comment.
Can we write a test where we can prove that last_sign_in updates accordingly?
Contributor
Author
There was a problem hiding this comment.
I wonder if it is appropriate here. We aren't writing any code that updates or creates the data. We are simply displaying it so I can test that we are grabbing the data that we say we are grabbing but checking for updates of that data from session to session would be tested elsewhere.
mdiarra3
reviewed
Oct 6, 2025
mdiarra3
reviewed
Oct 6, 2025
mdiarra3
approved these changes
Oct 7, 2025
jmdembe
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16741
🛠 Summary of changes
We were previously populating the 'last logged in' field, displayed on the duplicate profile page, with the
last_signed_inon from theEmailAddressmodel. It is inaccurate for a few reasons so we updated it to be populated withlast_authenticated_atfrom theServiceProviderIdentity.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots