Skip to content

[LG-16741] Fix last logged in on duplicate profile page#12555

Merged
joshuaalley25 merged 2 commits intomainfrom
jra/LG-16741-never-logged-in-bug
Oct 7, 2025
Merged

[LG-16741] Fix last logged in on duplicate profile page#12555
joshuaalley25 merged 2 commits intomainfrom
jra/LG-16741-never-logged-in-bug

Conversation

@joshuaalley25
Copy link
Copy Markdown
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-16741

🛠 Summary of changes

We were previously populating the 'last logged in' field, displayed on the duplicate profile page, with the last_signed_in on from the EmailAddress model. It is inaccurate for a few reasons so we updated it to be populated with last_authenticated_at from the ServiceProviderIdentity.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: Recreate duplicate account scenario by creating two accounts and signing into a SP requiring Facial Match
  • Step 2: You will be redirected to a duplicate accounts page as shown in the image below
  • Step 3: You should see the last login date populated

👀 Screenshots

Screenshot 2025-10-03 at 12 58 59 PM

changelog: Bug Fixes, One Account, replace how we are displaying last login for duplicate accounts
@joshuaalley25 joshuaalley25 requested a review from a team October 3, 2025 20:05
:duplicate_profile_set,
profile_ids: [user.active_profile.id, profile2.id],
service_provider: 'test-sp',
service_provider: sp,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write a test where we can prove that last_sign_in updates accordingly?

Copy link
Copy Markdown
Contributor Author

@joshuaalley25 joshuaalley25 Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is appropriate here. We aren't writing any code that updates or creates the data. We are simply displaying it so I can test that we are grabbing the data that we say we are grabbing but checking for updates of that data from session to session would be tested elsewhere.

@joshuaalley25 joshuaalley25 merged commit fc2a3b9 into main Oct 7, 2025
1 check passed
@joshuaalley25 joshuaalley25 deleted the jra/LG-16741-never-logged-in-bug branch October 7, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants