Conversation
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Ran through the test plan and things LGTM! 👍🏻
app/jobs/resolution_proofing_job.rb
Outdated
| @@ -26,7 +26,7 @@ def perform( | |||
| service_provider_issuer: nil, | |||
| threatmetrix_session_id: nil, | |||
| request_ip: nil, | |||
| proofing_components: nil | |||
| proofing_components: nil # rubocop:disable Lint/UnusedMethodArgument | |||
There was a problem hiding this comment.
Is this to be cleaned up later? If so I would consider removing proofing_components from this from places where this is called. That way if/when it is removed we won't have jobs enqueued with this extra parameter.
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Looks great - only request is to update the report to get rid of the "non-shadow" designation.
| @@ -73,7 +73,6 @@ def api_transaction_count | |||
| 'Instant verify', | |||
| 'Phone Finder', | |||
| 'Socure (DocV)', | |||
| 'Socure (KYC) - Shadow', | |||
| 'Socure (KYC) - Non-Shadow', | |||
There was a problem hiding this comment.
I think it's worth going through and removing the "non-shadow" label as well.
| @@ -37,11 +36,11 @@ | |||
|
|
|||
| expect(header_row).to eq( | |||
| ['Week', 'True ID', 'Instant verify', 'Phone Finder', 'Socure (DocV)', | |||
| 'Socure (KYC) - Shadow', 'Socure (KYC) - Non-Shadow', | |||
| 'Socure (KYC) - Non-Shadow', | |||
There was a problem hiding this comment.
As above, I think it's worth getting rid of the "Non-Shadow' designation.
AShukla-GSA
left a comment
AShukla-GSA
left a comment
There was a problem hiding this comment.
Tested and Review. LGTM
4 participants
changelog: Internal, Code cleanup, Remove KYC Shadowmode evaluation code
🎫 Ticket
LG-16417
🛠 Summary of changes
Removed KYC Shadowmode code from the codebase.
Deleted:
SocureShadowModeProofingJoband test fileSOCURE_IDV_SHADOW_MODE_FOR_NON_DOCV_USERSA/B testResolutionProofingJob📜 Testing Plan
Provide a checklist of steps to confirm the changes.
make lintpasses