LG-16803 Add issuing country code to pii bundle#12547
Conversation
| @@ -188,6 +188,10 @@ def true_id_response_passport_card | |||
| read_fixture_file_at_path('true_id/true_id_response_success_passport_card.json') | |||
| end | |||
|
|
|||
| def true_id_response_passport_without_tamper | |||
| read_fixture_file_at_path('true_id/true_id_response_success_passport_without_tamper.json') | |||
There was a problem hiding this comment.
I created this because I was getting an issue with the normal success_passport with logging extra params
shanechesnutt-ft
force-pushed
the
sc/LG-16803
branch
from
cd2631d to
594f3b4
Compare
shanechesnutt-ft
requested review from
AShukla-GSA,
Mawar2,
WilliamBirdsall,
amirbey,
solipet and
theabrad
changelog: Internal, IDV, Add issuing country code to pii bundle
shanechesnutt-ft
force-pushed
the
sc/LG-16803
branch
from
594f3b4 to
d8f473f
Compare
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Looks great - one question to think about, but not a blocker.
| identity_doc_zipcode: nil, | ||
| identity_doc_address_state: nil, | ||
| state_id_jurisdiction: nil, | ||
| issuing_country_code: 'USA', |
There was a problem hiding this comment.
This may be a result of the fixture (and thus in practice out of our control), but the Jira ticket specified the value should be either 'US' or 'Department of State'.
Does it matter?
There was a problem hiding this comment.
I am not sure this matters for the tests. It will take a string.
There was a problem hiding this comment.
I will check with Amir on this though.
| identity_doc_zipcode: nil, | ||
| identity_doc_address_state: nil, | ||
| state_id_jurisdiction: 'NY', | ||
| issuing_country_code: 'USA', |
There was a problem hiding this comment.
Same as above - does this need to be US?
Mawar2
left a comment
Mawar2
left a comment
There was a problem hiding this comment.
LGTM - got clarity "USA" being referenced instead of "US" as stated in the ticket. But it seems like our existing fixtures have "USA for passport, US for state_id" so we are just following that convention here.
AShukla-GSA
left a comment
AShukla-GSA
left a comment
There was a problem hiding this comment.
Tested Locally and Reviewed. LGTM
5 participants
changelog: Internal, IDV, Add issuing country code to pii bundle
🎫 Ticket
Link to the relevant ticket:
LG-16803
🛠 Summary of changes
Add issuing country code to pii bundle.
📜 Testing Plan
Manual Testing:
Scenario: Passport
pii_attributesvariable