Skip to content

Enable freezing string literals when running tests in CI #12541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Sep 30, 2025
Merged

Enable freezing string literals when running tests in CI #12541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ specs:
AWS_REGION: us-west-2
AWS_SECRET_ACCESS_KEY: test
CAPYBARA_WAIT_TIME_SECONDS: 5
RUBYOPT: '--enable=frozen-string-literal'
COVERAGE: 'true'
DOCKER_DB_HOST: db-postgres
POSTGRES_DB: identity_idp_test
Expand Down
2 changes: 1 addition & 1 deletion spec/bin/aamva-test-cert_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_cert(auth_url:, verification_url:)

describe '#run' do
subject(:run) { instance.run(out: out, argv: argv) }
let(:out) { StringIO.new('') }
let(:out) { StringIO.new(+'') }
let(:argv) { [] }

context 'missing arguments' do
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/headers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
end

it 'does not raise an error when HTTP_HOST Header is encoded with ASCII-8BIT' do
get root_path, headers: { 'Host' => '¿’¿”'.force_encoding(Encoding::ASCII_8BIT) }
get root_path, headers: { 'Host' => (+'¿’¿”').force_encoding(Encoding::ASCII_8BIT) }

expect(response.status).to eq 200
end
Expand Down
2 changes: 1 addition & 1 deletion spec/services/barcode_outputter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

it 'returns image data' do
# See: https://en.wikipedia.org/wiki/List_of_file_signatures
png_signature = "\x89\x50\x4e\x47\x0d\x0a\x1a\x0a".force_encoding(Encoding::ASCII_8BIT)
png_signature = (+"\x89\x50\x4e\x47\x0d\x0a\x1a\x0a").force_encoding(Encoding::ASCII_8BIT)
expect(image_data).to start_with(png_signature)
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/services/encrypted_redis_struct_storage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def self.redis_key_prefix

context 'with funky ASCII data inside the struct' do
let(:data) do
"HTTP Status 401 \xE2\x80\x93 Unauthorized".force_encoding('ASCII-8BIT').freeze
(+"HTTP Status 401 \xE2\x80\x93 Unauthorized").force_encoding('ASCII-8BIT').freeze
end

it 'converts the data and stores it' do
Expand Down