LG-16729 Add Preconditions to ChooseIdTypeController's Flow Policy

[WilliamBirdsall]

🎫 Ticket

Link to the relevant ticket:
LG-16729

🛠 Summary of changes

Add Preconditions to ChooseIdTypeController

Notes:

• The previous ticket that this ticket depends on adds tests to flow_policy_spec.
• This ticket specifies adding preconditions to the hybrid choose id type controller but hybrid does not use the flow policy.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Step 1: Create new account and navigate a few screen into IPP.
• Step 2: Attempt to navigate via a URL change to verify/choose_id_type
• Step 3: Ensure you are not navigated there

[amirbey]

Suggested change

	idv_session.flow_path == 'standard' && (
	!idv_session.skip_doc_auth_from_handoff || # is not ipp from desktop
	idv_session.skip_hybrid_handoff || # is not mobile user
	!idv_session.skip_doc_auth_from_how_to_verify || # is not ipp user
	!idv_session.selfie_check_required || # desktop but selfie not required
	idv_session.desktop_selfie_test_mode_enabled?
	)
	idv_session.flow_path == 'standard' &&
	!idv_session.skip_doc_auth_from_handoff && # is not ipp from desktop
	!idv_session.skip_doc_auth_from_how_to_verify

[amirbey]

selfie_check_required is no longer relevant ...
and ,the standard_flow is true if either idv_session.desktop_selfie_test_mode_enabled? or idv_session.skip_hybrid_handoff is true

for hybrid flow:
i think adding a before filter to hybrid document_capture_controller:

def id_type_chosen?
  document_capture_session.passport_status.present?
end

[WilliamBirdsall]

There is already a before action on hybrid doc capture controller:

before_action :ensure_choose_id_type_completed, only: :show

Would this suffice?

[WilliamBirdsall]

It appears to be doing the same check

[solipet]

Tested against the branch and against main - worked great!

Could we add a feature spec to demonstrate this? Maybe in spec/features/idv/doc_auth/choose_id_type_spec.rb?

[WilliamBirdsall]

Spec test added!

[shanechesnutt-ft]

LGTM! 👍🏻

[solipet]

LGTM