-
Notifications
You must be signed in to change notification settings - Fork 166
Team Data 1105(feature) Add Fraud Ops Tracking for data warehouse and FCMS #12503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
55007cb
d5d7f4f
9945058
0ca1a40
50550a6
58ba2f1
7a5b203
dcf73c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,12 +11,16 @@ class RegistrationsController < ApplicationController | |
| CREATE_ACCOUNT = 'create_account' | ||
|
|
||
| def new | ||
| @register_user_email_form = RegisterUserEmailForm.new(analytics:, attempts_api_tracker:) | ||
| @register_user_email_form = RegisterUserEmailForm.new( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [request] can we remove these kinds of style-based changes that aren't necessary in files that wouldn't otherwise be touched? it's making this PR a bit noisier
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah i think it's some over zealous format on save happening. 😬
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there's just a couple of them, so i suppose it's not a big deal (i was just noting them as i went through, so wasn't sure how much it was adding to the PR) |
||
| analytics:, attempts_api_tracker:, | ||
| ) | ||
| analytics.user_registration_enter_email_visit | ||
| end | ||
|
|
||
| def create | ||
| @register_user_email_form = RegisterUserEmailForm.new(analytics:, attempts_api_tracker:) | ||
| @register_user_email_form = RegisterUserEmailForm.new( | ||
| analytics:, attempts_api_tracker:, | ||
| ) | ||
|
|
||
| result = @register_user_email_form.submit(permitted_params.merge(request_id:)) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I'm only tracking IdV events.