LG-16722: remove passport A/B and allowed

app/controllers/concerns/idv/choose_id_type_concern.rb

@@ -57,13 +57,21 @@ def dos_passport_api_healthy?(
     end
 
     def locals_attrs(presenter:, form_submit_url: nil)
-      disable_passports = params.permit(:passports)[:passports].present?
       {
         presenter:,
         form_submit_url:,
-        disable_passports:,
-        auto_check_value: disable_passports ? :drivers_license : selected_id_type,
+        disable_passports: disable_passports?,
+        auto_check_value: disable_passports? ? :drivers_license : selected_id_type,
       }
     end
+
+    def disable_passports?
+      !passports_enabled? ||
+        params.permit(:passports)[:passports].present?
+    end
+
+    def passports_enabled?
+      IdentityConfig.store.doc_auth_passports_enabled
+    end
   end
 end

app/controllers/concerns/idv_step_concern.rb

@@ -73,10 +73,8 @@ def confirm_hybrid_handoff_needed
 
       if in_person_proofing_route_enabled?
         redirect_to idv_how_to_verify_url
-      elsif idv_session.passport_allowed
-        redirect_to idv_choose_id_type_url
       else
-        redirect_to vendor_document_capture_url
+        redirect_to idv_choose_id_type_url
       end
     end
   end
@@ -101,7 +99,8 @@ def vendor_document_capture_url
   end
 
   def in_person_passports_allowed?
-    IdentityConfig.store.in_person_passports_enabled && document_capture_session.passport_allowed?
+    IdentityConfig.store.doc_auth_passports_enabled &&
+      IdentityConfig.store.in_person_passports_enabled
   end
 
   private

app/controllers/idv/choose_id_type_controller.rb

@@ -7,7 +7,6 @@ class ChooseIdTypeController < ApplicationController
     include StepIndicatorConcern
     include Idv::ChooseIdTypeConcern
 
-    before_action :redirect_if_passport_not_available
     before_action :confirm_step_allowed
 
     def show
@@ -49,25 +48,20 @@ def self.step_info
         controller: self,
         next_steps: [:document_capture],
         preconditions: ->(idv_session:, user:) do
-          idv_session.flow_path == 'standard' &&
-          idv_session.passport_allowed == true
+          idv_session.flow_path == 'standard'
         end,
         undo_step: ->(idv_session:, user:) do
           if idv_session.document_capture_session_uuid
             DocumentCaptureSession.find_by(
               uuid: idv_session.document_capture_session_uuid,
-            )&.update!(passport_status: idv_session.passport_allowed ? 'allowed' : nil)
+            )&.update!(passport_status: nil)
           end
         end,
       )
     end
 
     private
 
-    def redirect_if_passport_not_available
-      redirect_to idv_how_to_verify_url if !idv_session.passport_allowed
-    end
-
     def next_step
       idv_document_capture_url
     end

app/controllers/idv/how_to_verify_controller.rb

@@ -38,11 +38,9 @@ def update
           idv_session.skip_doc_auth_from_how_to_verify = false
           idv_session.flow_path = 'standard'
           abandon_any_ipp_progress
-          if idv_session.passport_allowed
-            redirect_to idv_choose_id_type_url
-          else
-            redirect_to idv_document_capture_url
-          end
+
+          redirect_to idv_choose_id_type_url
+
         else
           idv_session.opted_in_to_in_person_proofing = true
           idv_session.flow_path = 'standard'
@@ -102,7 +100,6 @@ def set_how_to_verify_presenter
       @presenter = Idv::HowToVerifyPresenter.new(
         mobile_required: @mobile_required,
         selfie_check_required: @selfie_required,
-        passport_allowed: idv_session.passport_allowed,
       )
     end
 

app/controllers/idv/hybrid_handoff_controller.rb

@@ -92,7 +92,6 @@ def set_how_to_verify_presenter
       @presenter = Idv::HowToVerifyPresenter.new(
         mobile_required: mobile_required?,
         selfie_check_required: @selfie_required,
-        passport_allowed: idv_session.passport_allowed,
       )
     end
 
@@ -170,7 +169,7 @@ def update_document_capture_session_requested_at(session_uuid)
 
     def bypass_send_link_steps
       idv_session.flow_path = 'standard'
-      redirect_to next_step
+      redirect_to idv_choose_id_type_url
 
       analytics.idv_doc_auth_hybrid_handoff_submitted(
         **analytics_arguments.merge(
@@ -179,14 +178,6 @@ def bypass_send_link_steps
       )
     end
 
-    def next_step
-      if idv_session.passport_allowed
-        idv_choose_id_type_url
-      else
-        idv_document_capture_url
-      end
-    end
-
     def extra_view_variables
       { idv_phone_form: build_form }
     end

app/controllers/idv/hybrid_mobile/choose_id_type_controller.rb

@@ -9,7 +9,6 @@ class ChooseIdTypeController < ApplicationController
       include Idv::ChooseIdTypeConcern
 
       before_action :check_valid_document_capture_session
-      before_action :redirect_if_passport_not_available, only: :show
 
       def show
         analytics.idv_doc_auth_choose_id_type_visited(**analytics_arguments)
@@ -44,12 +43,6 @@ def update
 
       private
 
-      def redirect_if_passport_not_available
-        unless document_capture_session.passport_allowed?
-          redirect_to idv_hybrid_mobile_document_capture_url
-        end
-      end
-
       def next_step
         idv_hybrid_mobile_document_capture_url
       end

app/controllers/idv/hybrid_mobile/entry_controller.rb

@@ -14,12 +14,7 @@ def show
 
         return handle_invalid_document_capture_session if !validate_document_capture_user_id
 
-        if document_capture_session.passport_allowed?
-          redirect_to idv_hybrid_mobile_choose_id_type_url
-          return
-        end
-
-        redirect_to idv_hybrid_mobile_document_capture_url
+        redirect_to idv_hybrid_mobile_choose_id_type_url
       end
 
       private

app/controllers/idv/in_person/choose_id_type_controller.rb

@@ -53,7 +53,7 @@ def self.step_info
         if idv_session.document_capture_session_uuid && user.has_establishing_in_person_enrollment?
           DocumentCaptureSession.find_by(
             uuid: idv_session.document_capture_session_uuid,
-          )&.update!(passport_status: idv_session.passport_allowed ? 'allowed' : nil)
+          )&.update!(passport_status: nil)
         end
       end,
     )

app/controllers/idv/welcome_controller.rb

@@ -10,25 +10,21 @@ class WelcomeController < ApplicationController
     before_action :confirm_step_allowed
     before_action :confirm_not_rate_limited
     before_action :cancel_previous_in_person_enrollments, only: :show
-    before_action :update_passport_allowed,
-                  only: :show,
-                  if: -> { IdentityConfig.store.doc_auth_passports_enabled }
 
     def show
-      idv_session.proofing_started_at ||= Time.zone.now.iso8601
       analytics.idv_doc_auth_welcome_visited(**analytics_arguments)
 
       Funnel::DocAuth::RegisterStep.new(current_user.id, sp_session[:issuer])
         .call('welcome', :view, true)
 
       @presenter = Idv::WelcomePresenter.new(
         decorated_sp_session:,
-        passport_allowed: idv_session.passport_allowed,
       )
     end
 
     def update
       clear_future_steps!
+      idv_session.proofing_started_at ||= Time.zone.now.iso8601
       create_document_capture_session
       analytics.idv_doc_auth_welcome_submitted(**analytics_arguments)
       idv_session.welcome_visited = true
@@ -45,7 +41,6 @@ def self.step_info
         undo_step: ->(idv_session:, user:) do
           idv_session.welcome_visited = nil
           idv_session.document_capture_session_uuid = nil
-          idv_session.passport_allowed = nil
         end,
       )
     end
@@ -56,15 +51,13 @@ def analytics_arguments
       {
         step: 'welcome',
         analytics_id: 'Doc Auth',
-        passport_allowed: idv_session.passport_allowed,
       }.merge(ab_test_analytics_buckets)
     end
 
     def create_document_capture_session
       document_capture_session = DocumentCaptureSession.create!(
         user_id: current_user.id,
         issuer: sp_session[:issuer],
-        passport_status:,
       )
       idv_session.document_capture_session_uuid = document_capture_session.uuid
     end
@@ -74,13 +67,5 @@ def cancel_previous_in_person_enrollments
         current_user,
       )
     end
-
-    def update_passport_allowed
-      idv_session.passport_allowed ||= ab_test_bucket(:DOC_AUTH_PASSPORT) == :passport_allowed
-    end
-
-    def passport_status
-      :allowed if idv_session.passport_allowed
-    end
   end
 end

app/models/document_capture_session.rb

@@ -7,7 +7,6 @@ class DocumentCaptureSession < ApplicationRecord
   belongs_to :user
 
   PASSPORT_STATUSES = [
-    'allowed',
     'not_requested',
     'requested',
   ].freeze
@@ -108,10 +107,6 @@ def confirm_ocr
     update!(ocr_confirmation_pending: false)
   end
 
-  def passport_allowed?
-    PASSPORT_STATUSES.include? passport_status
-  end
-
   def passport_requested?
     passport_status == 'requested'
   end

app/presenters/idv/how_to_verify_presenter.rb

@@ -4,12 +4,11 @@ class Idv::HowToVerifyPresenter
   include ActionView::Helpers::TagHelper
   include ActionView::Helpers::TranslationHelper
 
-  attr_reader :mobile_required, :selfie_required, :passport_allowed
+  attr_reader :mobile_required, :selfie_required
 
-  def initialize(mobile_required:, selfie_check_required:, passport_allowed:)
+  def initialize(mobile_required:, selfie_check_required:)
     @mobile_required = mobile_required
     @selfie_required = selfie_check_required
-    @passport_allowed = passport_allowed
   end
 
   def how_to_verify_info
@@ -51,11 +50,7 @@ def verify_online_instruction
   end
 
   def verify_online_description
-    if passport_allowed
-      t('doc_auth.info.verify_online_description_passport')
-    else
-      ''
-    end
+    t('doc_auth.info.verify_online_description_passport')
   end
 
   def online_submit
@@ -83,13 +78,9 @@ def post_office_accepted_id_instruction
   end
 
   def post_office_description
-    if passport_allowed
-      IdentityConfig.store.in_person_passports_enabled ?
+    IdentityConfig.store.in_person_passports_enabled ?
       t('doc_auth.info.verify_online_description_passport') :
       t('doc_auth.info.verify_at_post_office_description_passport_html')
-    else
-      ''
-    end
   end
 
   def post_office_submit

app/presenters/idv/welcome_presenter.rb

@@ -14,9 +14,8 @@ class WelcomePresenter
 
     attr_accessor :url_options
 
-    def initialize(decorated_sp_session:, passport_allowed:)
+    def initialize(decorated_sp_session:)
       @decorated_sp_session = decorated_sp_session
-      @passport_allowed = passport_allowed
       @url_options = {}
     end
 
@@ -69,16 +68,14 @@ def bullet_points
 
     private
 
-    attr_reader :decorated_sp_session, :passport_allowed
+    attr_reader :decorated_sp_session
 
     def current_user
       decorated_sp_session&.current_user
     end
 
     def id_type_copy
-      return t('doc_auth.instructions.bullet1b') if passport_allowed
-
-      t('doc_auth.instructions.bullet1a')
+      t('doc_auth.instructions.bullet1')
     end
 
     def bullet_point(bullet, text)

app/services/analytics_events.rb

@@ -2392,13 +2392,11 @@ def idv_doc_auth_warning_visited(step_name:, remaining_submit_attempts:, **extra
   # User submits IdV welcome screen
   # @param [String] step Current IdV step
   # @param [String] analytics_id Current IdV flow identifier
-  # @param [Boolean] passport_allowed Whether passport is allowed for document capture
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   def idv_doc_auth_welcome_submitted(
     step:,
     analytics_id:,
-    passport_allowed:,
     opted_in_to_in_person_proofing: nil,
     skip_hybrid_handoff: nil,
     **extra
@@ -2407,7 +2405,6 @@ def idv_doc_auth_welcome_submitted(
       'IdV: doc auth welcome submitted',
       step:,
       analytics_id:,
-      passport_allowed:,
       opted_in_to_in_person_proofing:,
       skip_hybrid_handoff:,
       **extra,
@@ -2417,13 +2414,11 @@ def idv_doc_auth_welcome_submitted(
   # User visits IdV welcome screen
   # @param [String] step Current IdV step
   # @param [String] analytics_id Current IdV flow identifier
-  # @param [Boolean] passport_allowed Whether passport is allowed for document capture
   # @param [Boolean] skip_hybrid_handoff Whether skipped hybrid handoff A/B test is active
   # @param [Boolean] opted_in_to_in_person_proofing User opted into in person proofing
   def idv_doc_auth_welcome_visited(
     step:,
     analytics_id:,
-    passport_allowed:,
     opted_in_to_in_person_proofing: nil,
     skip_hybrid_handoff: nil,
     **extra
@@ -2432,7 +2427,6 @@ def idv_doc_auth_welcome_visited(
       'IdV: doc auth welcome visited',
       step:,
       analytics_id:,
-      passport_allowed:,
       skip_hybrid_handoff:,
       opted_in_to_in_person_proofing:,
       **extra,