Skip to content

LG-16683: choose doc auth vendor after choose id type#12448

Merged
amirbey merged 19 commits intomainfrom
amirbey/doc-auth-vendor-after-choose-id-type
Aug 26, 2025
Merged

LG-16683: choose doc auth vendor after choose id type#12448
amirbey merged 19 commits intomainfrom
amirbey/doc-auth-vendor-after-choose-id-type

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Aug 22, 2025

🎫 Ticket

LG-16683

🛠 Summary of changes

DocAuthVendor is chosen based upon the document selection on the Choose ID Type Screen

📜 Testing Plan

Below is demonstration in Choose ID Type feature specs:

# application.yml
doc_auth_passports_enabled: true
doc_auth_passports_percent: 100
doc_auth_vendor_default: 'mock'
doc_auth_passport_vendor_default: 'socure'

TEST 1

  1. Step through IDV to Choose ID Type screen
  2. Verify that DocumentCaptureSesison.last.doc_auth_vendor is nil
  3. Submit License at Choose ID Type
  4. Verify that Verify that DocumentCaptureSesison.last.doc_auth_vendor is not nil
  5. Verify that Mock/LN Document Capture is rendered

Test 2

  1. Step through IDV to Choose ID Type screen
  2. Verify that DocumentCaptureSesison.last.doc_auth_vendor is nil
  3. Submit Passportr at Choose ID Type
  4. Verify that Verify that DocumentCaptureSesison.last.doc_auth_vendor is not nil
  5. Verify that Socure Document Capture is rendered

@amirbey amirbey changed the title choose doc auth vendor after choose id type LG-16683: choose doc auth vendor after choose id type Aug 25, 2025
@amirbey amirbey self-assigned this Aug 25, 2025
@amirbey amirbey marked this pull request as ready for review August 26, 2025 14:39
@amirbey amirbey requested a review from theabrad August 26, 2025 15:48
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall things look good just had a couple of questions before approving.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Newline above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be checked for both cases?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a cases for:

  • When facial match requested and passport requested
  • When facial match in not requested and passport requested

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these scenarios exist in feature specs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow this test. In this context block we should be testing doc_auth_vendor_enabled?.

Copy link
Contributor Author

@amirbey amirbey Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is testing when the doc_auth_vendor is set and if then the vendor is disabled in the IDP the vendor experience is unchanged for the user

Copy link
Contributor

@AShukla-GSA AShukla-GSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Reviewed. LGTM. Non blocking nit, the socure route did not load for me during testing.
Screenshot 2025-08-26 at 10 36 26 AM

Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, given others' comments.

@amirbey amirbey force-pushed the amirbey/doc-auth-vendor-after-choose-id-type branch from 1ca5d1f to 3a8319c Compare August 26, 2025 19:51
@amirbey amirbey merged commit db7e158 into main Aug 26, 2025
1 check passed
@amirbey amirbey deleted the amirbey/doc-auth-vendor-after-choose-id-type branch August 26, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants