LG-16446: Rename gpo_letter_requested (Part 1)#12434
Merged
Conversation
`idv_session.gpo_letter_requested` is renamed to `idv_session.gpo_request_letter_visited` to more accurately reflect the state being captured. This value is used when the user needs to go back and verify their mailing address which may be different from the address the user previously verified. changelog: Bug Fixes, GPO Letter request, Record that the request letter page has been visited.
mail step - we can't simply check for `t('idv.titles.mail.verify')`
(Verify by mail) because that phrase appears on the Phone step page in
the link to choose the GPO path. Changed to check for other content in
the body of the page instead.
Also found/fixed a bug where we weren't showing the GPO step indicator
steps when the user went back to enter their mailing address.
solipet
requested review from
AShukla-GSA,
Mawar2,
WilliamBirdsall,
amirbey,
shanechesnutt-ft and
theabrad
solipet
changed the title
shanechesnutt-ft
approved these changes
Aug 20, 2025
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Things look go to me. Nice work! 👍🏻
One thing that did stick out to me was a consideration for how we are interacting with items stored in the idv_session. I wonder if we can minimize the number of changes for 50/50 state PRs by using methods that handle storing and reading data from idv_session rather than interacting with the state directly. Then the only thing that needs to be done is updating those store and read methods. Maybe an improvement for the future.
mitchellhenke
pushed a commit
that referenced
this pull request
Aug 21, 2025
* LG-16625 fetch docv results before timeout (#12409) * add synchronous fetch if request is timed out * add analytics event of socure_webhook_missing * passing specs * change fetch method name for docv results * add changelog changelog: Bug Fixes, Doc Auth, fetch docv results synchronously if webhook queues are backed up * fix lint * remove socure test mode from feature specs * see if this passes feature specs * trying to pass feature spec again * remove unused context * LG-16330 Update selfie-specific error message content (#12403) * changelog: User-Facing Improvements, Identity Verification, Update error message for selfie portrait matching failures to provide clearer instructions on how to take a better photo * Fix YAML formatting in French locale * external contributor guidelines (#12429) * Update URL * Update EXTERNAL_CONTRIBUTORS.md * changelog: Internal, Documentation, External contributor guidelines --------- Co-authored-by: Jessica Dembe <jessica.dembe@gsa.gov> * Enable deprecation warnings in tests (#12436) * Enable deprecation warnings in tests changelog: Internal, Testing, Enable deprecation warnings in tests * use prism * Update Ruby and Yarn versions (#12380) * Update Ruby and Yarn versions changelog: Internal, Maintenance, Update Ruby and Yarn versions * Use specific version of chrome/chromedriver * update deps * update load paths test * update js dependencies * update deploy dockerfile * Bump libphonenumber-js from 1.12.12 to 1.12.13 (#12440) Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.12.12 to 1.12.13. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.12.12...v1.12.13) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-version: 1.12.13 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * LG-16446: Rename gpo_letter_requested (Part 1) (#12434) `idv_session.gpo_letter_requested` is renamed to `idv_session.gpo_request_letter_visited` to more accurately reflect the state being captured. This value is used when the user needs to go back and verify their mailing address which may be different from the address the user previously verified. changelog: Bug Fixes, GPO Letter request, Record that the request letter page has been visited. * Discovered a false positive when testing that we are on the Verify by mail step - we can't simply check for `t('idv.titles.mail.verify')` (Verify by mail) because that phrase appears on the Phone step page in the link to choose the GPO path. Changed to check for other content in the body of the page instead. Also found/fixed a bug where we weren't showing the GPO step indicator steps when the user went back to enter their mailing address. * defend against the 50/50 state * Update support-action to perform a way to unblock device profiling result (#12439) * changelog: Internal, Threatmetrix, Update Device profiling rake task to simplify for folks how we can process it * changelog: Internal, Threatmetrix account creation, add updating device profiling result to action-account * fix schema * add rspec for new action account subtask --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Malik Warren <33402370+Mawar2@users.noreply.github.com> Co-authored-by: Davi (she/they) <davida.marion@gsa.gov> Co-authored-by: Jessica Dembe <jessica.dembe@gsa.gov> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Doug Price <douglas.price@gsa.gov> Co-authored-by: Malick Diarra <malick.diarra@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16446
🛠 Summary of changes
Part 1 of 2 to avoid 50/50 problems
The idv_session flag
gpo_letter_requestedseems like, if set to true, would indicate that the user has requested a letter. This is not the case - this flag is set when the user visits the Verify by mail page, and it's purpose is to allow reuse on the address controller to modify the copy for the Mailing address entry. To avoid future confusion, we will rename this fieldgpo_request_letter_visited.This PR adds the field
gpo_request_letter_visited, writes to both new and old fields, and reads fromnew || old. In a follow-on PR, after this PR is deployed to prod, we will remove all references to the old name.While in here I noticed/fixed two other bugs:
t('idv.messages.gpo.address_on_file')which only appears on the request_letter page.gpo_request_letter_visitedand show the GPO steps if we will be returned to the request letter page.