LG-16581: DocAuth passport w/ selfie - TrueID#12412
Merged
Conversation
amirbey
changed the title
amirbey
requested review from
AShukla-GSA,
WilliamBirdsall,
solipet and
theabrad
and removed request for
AShukla-GSA
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
I think things are looking good. I was having trouble following the testing steps though... Maybe we can sync up on Monday
shanechesnutt-ft
approved these changes
Aug 20, 2025
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Retested after steps have been updated. Looks good to me! 👍🏻
amirbey
force-pushed
the
amirbey/LG-16851-trueid-passport-selfie
branch
from
d64ff96 to
4072bf0
Compare
solipet
changed the title
amirbey
force-pushed
the
amirbey/LG-16851-trueid-passport-selfie
branch
from
165cce6 to
5f43811
Compare
solipet
reviewed
Aug 21, 2025
Contributor
There was a problem hiding this comment.
Can we use the i18n key instead of a string constant?
Suggested change
| click_button 'Take photo' | |
| click_button t('doc_auth.buttons.take_picture') |
Contributor
There was a problem hiding this comment.
Suggested change
| click_button 'Take photo' | |
| click_button t('doc_auth.buttons.take_picture') |
Contributor
There was a problem hiding this comment.
Suggested change
| click_button 'Take photo' | |
| click_button t('doc_auth.buttons.take_picture') |
solipet
approved these changes
Aug 21, 2025
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Ran through the tests and everything worked as expected. Just my previous comments but those are non-blocking
changelog: Upcoming Features, Document Authentication, DocAuth with selfie using a passport as identity evidence
amirbey
force-pushed
the
amirbey/LG-16851-trueid-passport-selfie
branch
from
398c8b7 to
39c69f3
Compare
amirbey
commented
Aug 21, 2025
| failure_to_proof_url: return_to_sp_failure_to_proof_url(step: 'document_capture'), | ||
| doc_auth_selfie_capture: resolved_authn_context_result.facial_match?, | ||
| choose_id_type_path: choose_id_type_path, | ||
| choose_id_type_path: idv_hybrid_mobile_choose_id_type_path, |
Contributor
Author
There was a problem hiding this comment.
bug fix ... this was previously using standard flow choose id type path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-16581
🛠 Summary of changes
Allow passports if a selfie is required but default to TrueID as the DocAuthVendor
📜 Testing Plan
Test # 1
Test # 2
doc_auth_selfie_vendor_switching_enabled: falseTest # 3
doc_auth_passport_selfie_enabled: true