Skip to content

update montlhy key metrics to have a shorter cw window #12411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrNagoo merged 1 commit into from
Aug 11, 2025
Merged

update montlhy key metrics to have a shorter cw window #12411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/reporting/monthly_idv_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,7 @@ def parallel_reports
end

def monthly_subreports
ranges = [
(end_date - 2.months).all_month,
(end_date - 1.month).all_month,
end_date.all_month,
]
ranges = [end_date.all_month]
Copy link
Copy Markdown
Contributor Author

@MrNagoo MrNagoo Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the smallest reversible refactor I can think of.


ranges.map do |range|
Reporting::IdentityVerificationReport.new(
Expand Down
2 changes: 1 addition & 1 deletion lib/reporting/proofing_rate_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

module Reporting
class ProofingRateReport
DATE_INTERVALS = [30, 60, 90].freeze
DATE_INTERVALS = [30].freeze

attr_reader :end_date, :wait_duration

Expand Down
4 changes: 2 additions & 2 deletions spec/jobs/reports/monthly_key_metrics_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@

let(:mock_proofing_rate_data) do
[
['Metric', 'Trailing 30d', 'Trailing 60d', 'Trailing 90d'],
['Metric', 'Trailing 30d'],
]
end
let(:mock_monthly_idv_data) do
[
['Metric', 'June 2024', 'July 2024', 'August 2024'],
['Metric', 'Aug 2024'],
]
end

Expand Down
48 changes: 11 additions & 37 deletions spec/lib/reporting/monthly_idv_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,6 @@
before do
allow(idv_report).to receive(:reports).and_return(
[
instance_double(
'Reporting::IdentityVerificationReport',
time_range: Date.new(2024, 6, 1).all_month,
idv_started: 1111,
successfully_verified_users: 1111,
blanket_proofing_rate: 0.1111,
idv_final_resolution: 1111,
idv_final_resolution_rate: 0.1111,
verified_user_count: 1111,
),
instance_double(
'Reporting::IdentityVerificationReport',
time_range: Date.new(2024, 7, 1).all_month,
idv_started: 2222,
successfully_verified_users: 2222,
blanket_proofing_rate: 0.2222,
idv_final_resolution: 2222,
idv_final_resolution_rate: 0.2222,
verified_user_count: 2222,
),
instance_double(
'Reporting::IdentityVerificationReport',
time_range: Date.new(2024, 8, 1).all_month,
Expand All @@ -49,19 +29,17 @@

let(:expected_table) do
[
['Metric', 'Jun 2024', 'Jul 2024', 'Aug 2024'],
['IDV started', 1111, 2222, 3333],
['# of successfully verified users', 1111, 2222, 3333],
['% IDV started to successfully verified', 0.1111, 0.2222,
0.3333],
['# of workflow completed', 1111, 2222, 3333],
['% rate of workflow completed', 0.1111, 0.2222,
0.3333],
['# of users verified (total)', 1111, 2222, 3333],
['Metric', 'Aug 2024'],
['IDV started', 3333],
['# of successfully verified users', 3333],
['% IDV started to successfully verified', 0.3333],
['# of workflow completed', 3333],
['% rate of workflow completed', 0.3333],
['# of users verified (total)', 3333],
]
end

it 'reports 3 months of data' do
it 'reports 1 month of data' do
idv_report.as_csv.zip(expected_table).each do |actual, expected|
expect(actual).to eq(expected)
end
Expand Down Expand Up @@ -96,15 +74,11 @@
end

describe '#monthly_subreports' do
let(:june) { Date.new(2024, 6, 1).in_time_zone('UTC').all_month }
let(:july) { Date.new(2024, 7, 1).in_time_zone('UTC').all_month }
let(:august) { Date.new(2024, 8, 1).in_time_zone('UTC').all_month }

it 'returns IdV reports for the expected months' do
[june, july, august].each do |month|
expect(Reporting::IdentityVerificationReport).to receive(:new)
.with(issuers: nil, time_range: month, cloudwatch_client: anything)
end
it 'returns IdV report for the expected month' do
expect(Reporting::IdentityVerificationReport).to receive(:new)
.with(issuers: nil, time_range: august, cloudwatch_client: anything)

subject.monthly_subreports
end
Expand Down
73 changes: 19 additions & 54 deletions spec/lib/reporting/proofing_rate_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,60 +28,27 @@
idv_fraud_rejected: 0,
time_range: (end_date - 30.days).beginning_of_day..end_date,
),
instance_double(
'Reporting::IdentityVerificationReport',
blanket_proofing_rate: 0.4,
intent_proofing_rate: 0.5,
actual_proofing_rate: 0.6666666666666666,
industry_proofing_rate: 0.6666666666666666,
idv_started: 5,
idv_doc_auth_welcome_submitted: 4,
idv_doc_auth_socure_verification_data_requested: 0,
idv_doc_auth_image_vendor_submitted: 3,
successfully_verified_users: 2,
idv_doc_auth_rejected: 1,
idv_fraud_rejected: 1,
time_range: (end_date - 60.days).beginning_of_day..end_date,
),
instance_double(
'Reporting::IdentityVerificationReport',
blanket_proofing_rate: 0.5,
intent_proofing_rate: 0.6,
actual_proofing_rate: 0.75,
industry_proofing_rate: 0.75,
idv_started: 6,
idv_doc_auth_welcome_submitted: 5,
idv_doc_auth_image_vendor_submitted: 4,
idv_doc_auth_socure_verification_data_requested: 0,
successfully_verified_users: 3,
idv_doc_auth_rejected: 1,
idv_fraud_rejected: 2,
time_range: (end_date - 90.days).beginning_of_day..end_date,
),
],
)
end

it 'renders a report with 30, 60, 90 day numbers' do
# rubocop:disable Layout/LineLength
it 'renders a report with only 30 day numbers' do
expected_csv = [
['Metric', 'Trailing 30d', 'Trailing 60d', 'Trailing 90d'],
['Start Date', Date.new(2021, 12, 2), Date.new(2021, 11, 2), Date.new(2021, 10, 3)],
['End Date', Date.new(2022, 1, 1), Date.new(2022, 1, 1), Date.new(2022, 1, 1)],
['IDV Started', 4, 5, 6],
['Welcome Submitted', 3, 4, 5],
['Image Submitted', 2, 3, 4],
['Socure', 0, 0, 0],
['Successfully Verified', 1, 2, 3],
['IDV Rejected (Non-Fraud)', 1, 1, 1],
['IDV Rejected (Fraud)', 0, 1, 2],
['Blanket Proofing Rate (IDV Started to Successfully Verified)', 1.0 / 4, 2.0 / 5, 3.0 / 6],
['Intent Proofing Rate (Welcome Submitted to Successfully Verified)', 1.0 / 3, 2.0 / 4, 3.0 / 5],
['Actual Proofing Rate (Image Submitted to Successfully Verified)', 1.0 / 2, 2.0 / 3, 3.0 / 4],
['Industry Proofing Rate (Verified minus IDV Rejected)', 1.0 / 2, 2.0 / 3, 3.0 / 4],
['Metric', 'Trailing 30d'],
['Start Date', Date.new(2021, 12, 2)],
['End Date', Date.new(2022, 1, 1)],
['IDV Started', 4],
['Welcome Submitted', 3],
['Image Submitted', 2],
['Socure', 0],
['Successfully Verified', 1],
['IDV Rejected (Non-Fraud)', 1],
['IDV Rejected (Fraud)', 0],
['Blanket Proofing Rate (IDV Started to Successfully Verified)', 1.0 / 4],
['Intent Proofing Rate (Welcome Submitted to Successfully Verified)', 1.0 / 3],
['Actual Proofing Rate (Image Submitted to Successfully Verified)', 1.0 / 2],
['Industry Proofing Rate (Verified minus IDV Rejected)', 1.0 / 2],
]
# rubocop:enable Layout/LineLength

aggregate_failures do
report.as_csv.zip(expected_csv).each do |actual, expected|
expect(actual).to eq(expected)
Expand Down Expand Up @@ -141,8 +108,6 @@
expect(report.reports.map(&:time_range)).to eq(
[
(end_date - 30.days).beginning_of_day..end_date,
(end_date - 60.days).beginning_of_day..end_date,
(end_date - 90.days).beginning_of_day..end_date,
],
)

Expand All @@ -152,17 +117,17 @@
cloudwatch_client: report.cloudwatch_client,
).once

expect(Reporting::IdentityVerificationReport).to have_received(:new).with(
expect(Reporting::IdentityVerificationReport).not_to have_received(:new).with(
time_range: (end_date - 60.days).beginning_of_day..(end_date - 30.days).end_of_day,
issuers: nil,
cloudwatch_client: report.cloudwatch_client,
).once
)

expect(Reporting::IdentityVerificationReport).to have_received(:new).with(
expect(Reporting::IdentityVerificationReport).not_to have_received(:new).with(
time_range: (end_date - 90.days).beginning_of_day..(end_date - 60.days).end_of_day,
issuers: nil,
cloudwatch_client: report.cloudwatch_client,
).once
)
Comment on lines 119 to 130
Copy link
Copy Markdown
Contributor Author

@MrNagoo MrNagoo Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting, the idea is that these will come back to the report.

end
end
end
Expand Down