LG-16507: refactor agreements routing to next step#12410
Merged
Conversation
amirbey
force-pushed
the
amirbey/refactor-argreements-redirects
branch
from
fbc176d to
7b2ff94
Compare
amirbey
changed the title
…greements to DocAuth
amirbey
force-pushed
the
amirbey/refactor-argreements-redirects
branch
from
44fa897 to
6ef16f7
Compare
solipet
approved these changes
Aug 21, 2025
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
One suggestion in the spec, but otherwise looks good.
Comment on lines
+120
to
+135
| context 'when IPP proofing route is enabled' do | ||
| before do | ||
| allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true) | ||
| allow(IdentityConfig.store).to receive(:in_person_proofing_opt_in_enabled) | ||
| .and_return(true) | ||
| allow(IdentityConfig.store).to receive(:in_person_doc_auth_button_enabled) | ||
| .and_return(true) | ||
| allow(Idv::InPersonConfig).to receive(:enabled_for_issuer?).and_return(true) | ||
| end | ||
|
|
||
| it 'redirects to how to verify' do | ||
| get :show | ||
|
|
||
| expect(response).to redirect_to(idv_how_to_verify_url) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
If, instead, you had a sub-context with passport allowed under IPP is enabled, you would only have one repeated before action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-16507
🛠 Summary of changes
Consolidate routing logic from the agreements controller in the #confirm_hybrid_handoff filter already used by HybridHandoff for routing.