Skip to content

LG-16538: sms one account notifications#12408

Merged
mdiarra3 merged 3 commits intomainfrom
LG-16538-sms-one-account-notifications
Aug 14, 2025
Merged

LG-16538: sms one account notifications#12408
mdiarra3 merged 3 commits intomainfrom
LG-16538-sms-one-account-notifications

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Aug 8, 2025

🎫 Ticket

Link to the relevant ticket:
LG-16538

🛠 Summary of changes

Add Sms notifications for sign in or text attempts.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Verify all sms messages content is working as expected
  • Have a user A that has a duplicate profile on another account user B
  • Sign in using relevant SP
  • Land on the Duplicate Profile page
  • Receive an sms notification letting user B know that someone has signed in with their same profile information.
  • You can see outgoing text messages related to someone signing in from other account

@mdiarra3 mdiarra3 marked this pull request as ready for review August 12, 2025 12:57
@mdiarra3 mdiarra3 requested a review from a team August 13, 2025 16:41
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdiarra3 mdiarra3 merged commit c2d2e5b into main Aug 14, 2025
1 check passed
@mdiarra3 mdiarra3 deleted the LG-16538-sms-one-account-notifications branch August 14, 2025 18:36
mitchellhenke pushed a commit that referenced this pull request Aug 19, 2025
* LG-16538: sms one account notifications (#12408)

* changelog: Upcoming Features, One Account, Notify users via text message

* add changes

* fix translation error and rubocop

* Reset cookie when validating HTML markup in accessibility test to improve reliability (#12428)

changelog: Internal, Testing, Reset cookie when validating HTML markup in accessibility test to improve reliability

Co-authored-by: Davi (she/they) <davida.marion@gsa.gov>

* Bump libphonenumber-js from 1.12.10 to 1.12.12 (#12431)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.12.10 to 1.12.12.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.12.10...v1.12.12)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-version: 1.12.12
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Rails dependencies to patch vulnerabilities (#12433)

changelog: Internal, Maintenance, Update Rails dependencies to patch vulnerabilities

* Update rubyzip (#12435)

changelog: Internal, Maintenance, Update rubyzip

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Malick Diarra <malick.diarra@gsa.gov>
Co-authored-by: Davi (she/they) <davida.marion@gsa.gov>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants