LG-16371 Use constants for idv document types

[shanechesnutt-ft]

🎫 Ticket

Link to the relevant ticket:
LG-16371

🛠 Summary of changes

Create constants for idv document types

📜 Testing Plan

• Passing specs

[theabrad]

should we have Idp::Constants:DocumentTypes::STATE_ID_CARD here?

[shanechesnutt-ft]

I wasn't sure if this should be a constant or not. Maybe it should be the value that we send when you select state_id on the choose_id_type page.

[theabrad]

After a quick trace through where this method is called and ends up, we can take two paths:
The quick path would be to make a constant for state_id no card.
The other path would be to investigate all the uses of idType in the react portion of document capture. Starting at app/javascript/packages/document-capture/context/upload.tsx

[shanechesnutt-ft]

Looking into the latter today.

[shanechesnutt-ft]

I am actually wondering if it make more sense to use drivers_license here instead... That is the type that can be selected on the choose_id_type page. Thoughts?

[AShukla-GSA]

Agreed with earlier thread by alex, but otherwise LGTM

[theabrad]

LGTM

[solipet]

This is a HUGE improvement! I left a few optional suggestions - your choice.

[solipet]

nit

Suggested change

	`choose_id_type` #{@chosen_id_type} is invalid,
	`chosen_id_type` #{@chosen_id_type} is invalid,

[shanechesnutt-ft]

fixed

[solipet]

Maybe use the constants here?

Suggested change

	['passport', 'state_id_card', 'drivers_license'].each do |id_type|
	[
	Idp::Constants::DocumentTypes::PASSPORT,
	Idp::Constants::DocumentTypes::STATE_ID_CARD,
	Idp::Constants::DocumentTypes::DRIVERS_LICENSE,
	].each do |id_type|

[shanechesnutt-ft]

fixed

[AShukla-GSA]

LGTM!

[shanechesnutt-ft]

I talked to @solipet about this change and at the end of our conversation we felt that this value should be state_id_card. So I am reverting this commit