Conversation
astrogeco
reviewed
Aug 4, 2025
added 3 commits
August 4, 2025 18:46
edimeo-gsa
reviewed
Aug 6, 2025
|
|
||
| def verification_demand_results | ||
| data['IdV_IAL2_Start_User_count'].to_i || 0 | ||
| fetch_event_user_ids(Events::VERIFICATION_DEMAND).count |
Contributor
There was a problem hiding this comment.
Why are we executing multiple CW queries instead of doing a single query and doing counts by event? That's how the other reports utilize the CW Client
Contributor
There was a problem hiding this comment.
this may have been from my request to mimic the way you ran the demographics report @edimeo-gsa where you relied on ruby to parse out users from events for more performant cloudwatch queries.
Contributor
There was a problem hiding this comment.
but a single query to CW and then counting uuids based on event would make more sense.
edimeo-gsa
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-160
🛠 Summary of changes
Updated query to filter for @IdV_IAL2_Start = 1
Modified the query to be more performant by only considering max events and not sum-of-max events, using the report itself to calculate the total counts.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots