Skip to content

only IPP for SP as configured #12333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 2 commits into from
Jul 11, 2025
Merged

only IPP for SP as configured #12333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d05988e
only IPP for SP as configured
amirbey Jul 11, 2025
6fbaab0
add spec expectation
Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/controllers/idv/hybrid_handoff_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ def show
)
@post_office_enabled = IdentityConfig.store.in_person_proofing_enabled &&
IdentityConfig.store.in_person_proofing_opt_in_enabled &&
IdentityConfig.store.in_person_doc_auth_button_enabled
IdentityConfig.store.in_person_doc_auth_button_enabled &&
Idv::InPersonConfig.enabled_for_issuer?(
decorated_sp_session.sp_issuer,
)
@selfie_required = idv_session.selfie_check_required
@idv_how_to_verify_form = Idv::HowToVerifyForm.new
set_how_to_verify_presenter
Expand Down
3 changes: 3 additions & 0 deletions spec/features/idv/doc_auth/hybrid_handoff_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,14 +382,17 @@ def verify_no_upload_photos_section_and_link(page)
end
context 'when sp ipp is not available' do
let(:sp_ipp_enabled) { false }

describe 'when selfie is required by sp' do
let(:facial_match_required) { true }
it 'shows selfie version of top content, no ipp option section,
no upload section' do
verify_handoff_page_selfie_version_content(page)
verify_no_upload_photos_section_and_link(page)
verify_handoff_page_no_ipp_option_shown(page)
end
end

describe 'when selfie is not required by sp' do
let(:facial_match_required) { false }
it 'shows non selfie version of top content and upload section,
Expand Down