Merged
Conversation
vrajmohan
reviewed
Jul 11, 2025
Contributor
vrajmohan
left a comment
vrajmohan
left a comment
There was a problem hiding this comment.
Looks good. Wondering if there should be some sort of record that this profile was manually overridden.
jmdembe
reviewed
Jul 14, 2025
| uuid_list = user_uuids.split(',').map(&:strip).reject(&:blank?) | ||
|
|
||
| puts "Processing #{uuid_list.count} user UUID(s)" | ||
| puts "Action: Change 'reject' to 'pass' (skip if already 'pass')" |
Contributor
There was a problem hiding this comment.
I don't quite understand this. Is change/reject somehow associated with the uuids?
Contributor
Author
There was a problem hiding this comment.
yes its where we are changing the TMX device profile object from reject to pass since it was wrongly flagged as a reject.
Contributor
Author
There was a problem hiding this comment.
This action is just listing what will be happening throughout the script.
vrajmohan
approved these changes
Jul 14, 2025
Contributor
vrajmohan
left a comment
vrajmohan
left a comment
There was a problem hiding this comment.
Looks good. Thank you for adding the notes field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16404
🛠 Summary of changes
adds a rake task to update users that were impacted by the tmx launch when going through the piv cac recommended flow.