LG-16389 MRZ validation only performed if passport is requested and submitted

[theabrad]

🎫 Ticket

Link to the relevant ticket:
LG-16389

🛠 Summary of changes

Ensure that DOS MRZ validation is only performed if a passport is requested at the "choose your id" step and that it only occurs if the document uploaded is a passport.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Go through IdV and select Passport
• Verify that a passing passport yml succeeds and lets you go to the SSN step
• Start over and try using a driver's license and verify that it does not let you pass to the SSN step.

[Mawar2]

LGTM!

Minor note for future consideration -- we could add test coverage for edge cases (passport submitted when not requested, passport requested but not submitted), but not blocking.

[amirbey]

Suggested change

	document_capture_session&.passport_requested?
	!!document_capture_session&.passport_requested?

[amirbey]

LGTM!

Minor note for future consideration -- we could add test coverage for edge cases (passport submitted when not requested, passport requested but not submitted), but not blocking.

Adding on to @Mawar2 suggestion , can we add specs to ensure do not perform MRZ validation for these scenarios?

[theabrad]

LGTM!
Minor note for future consideration -- we could add test coverage for edge cases (passport submitted when not requested, passport requested but not submitted), but not blocking.

Adding on to @Mawar2 suggestion , can we add specs to ensure do not perform MRZ validation for these scenarios?

Added a test for passport submitted when not requested. There is already a test for passport requested, but not submitted https://github.com/18F/identity-idp/blob/main/spec/forms/idv/api_image_upload_form_spec.rb#L1001