lg-16379 document_type for proofing components

[AShukla-GSA]

🎫 Ticket

Link to the relevant ticket:
LG-16379

🛠 Summary of changes

Updating proofing component to support passport, state_id, and drivers_license doc type

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Step 1 - Confirm specs pass and test functionality

[mitchellhenke]

is drivers_license one of the document types?

[AShukla-GSA]

I believe we want to separate into 2 groups (state_id or passport). Previously the method only sent out state_id (drivers_license, state_id, etc.), this ticket is to update for passport. I'll need to check to support passport_cards

[solipet]

It is - not sure why we previously only showed state_id for everything. Seems like we should just pass id_doc_type through as is.

[mitchellhenke]

is it possible to have an explicit list of the allowed values? part of the issue in this case was a lack of an exhaustive list and relying on a fallback

is it possible to do something like

case session[:pii_from_doc][:id_doc_type]
when 'passport'
  'passport'
when 'state_id', 'drivers_license'
  'state_id'
else
  raise "Unexpected doc type #{session[:pii_from_doc][:id_doc_type]}"
end

[amirbey]

it appears that document_type in proofing components is mainly used for analytics ... 🤔

i added suggestion to remove this method as I do not think it is needed. it's existence brings into question whether an exception should be raised as posed by @mitchellhenke

[mitchellhenke]

I think the critical usage is that it serves as the authoritative record on the profile of the document submitted and verification steps done. If at some point in the future we need to see every active profile that used a passport as the document or used GPO for address verification, we should be able to refer to proofing_components.

[solipet]

It is - not sure why we previously only showed state_id for everything. Seems like we should just pass id_doc_type through as is.

[solipet]

LGTM

[mitchellhenke]

Worth being explicit that the changes here are not just adding passport as a document type in proofing components