-
Notifications
You must be signed in to change notification settings - Fork 166
LG-16378: ID_TYPE_SLUGS for stateID vs passports #12301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
396b22d
3bec557
45ca544
e5333f1
15cf12e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -201,7 +201,7 @@ def parse_date(date_string) | |
| end | ||
|
|
||
| def id_type_supported? | ||
| DocAuth::Response::SOCURE_ID_TYPE_SLUGS.key?(document_id_type) | ||
| DocAuth::Response::STATE_ID_TYPE_SLUGS.key?(document_id_type) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't there be an update to the Lexis Nexis response. I feel like it should have a similar setup with
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would most likely need to be new ticket
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking the same
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the update to the LN response is handled here |
||
| end | ||
|
|
||
| def reason_codes_selfie_pass | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,5 +104,18 @@ | |
| expect(response).to redirect_to idv_hybrid_mobile_document_capture_url | ||
| end | ||
| end | ||
|
|
||
| context 'user chooses passport' do | ||
| let(:chosen_id_type) { 'passport' } | ||
| let(:params) do | ||
| { doc_auth: { choose_id_type_preference: chosen_id_type } } | ||
| end | ||
|
|
||
| it 'sets passport_status to requested and redirects to vendor that supports passport' do | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Newline before it block |
||
| put :update, params: params | ||
| expect(document_capture_session.passport_status).to eq('requested') | ||
| expect(response).to redirect_to idv_hybrid_mobile_document_capture_url | ||
| end | ||
| end | ||
| end | ||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe define ID_TYPE_SLUGS after STATE_ID_TYPE_SLUGS so we eliminate the repeated strings?