Skip to content

LG-16075: Duplicate submission error handling at sign up completion #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmdembe merged 16 commits into from
Jul 1, 2025
Merged

LG-16075: Duplicate submission error handling at sign up completion #12273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
687a390
add rescue to prevent `RecordNotUnique` error
jmdembe Jun 18, 2025
d26b50b
change course, `create_or_find_by` agency id
jmdembe Jun 23, 2025
c60e991
add service provider check
jmdembe Jun 23, 2025
25b814d
raise exception of agency identity is not found
jmdembe Jun 23, 2025
277e76e
make variables make sense
jmdembe Jun 23, 2025
8b47d12
fix `next_setup_path`
jmdembe Jun 23, 2025
e2208d9
add test for multiple SP identities
Jun 23, 2025
a17c544
use `begin...rescue` in service
jmdembe Jun 23, 2025
9540150
look for agency identity first, then create if multiple records are f…
jmdembe Jun 24, 2025
7845957
do `find_or_create_by`, search using uuid
jmdembe Jun 24, 2025
b6e2cfe
get rid of `do` statement
jmdembe Jun 24, 2025
f6479d9
fix logic for create and find
jmdembe Jun 26, 2025
2f448c0
replace to create
jmdembe Jun 26, 2025
995b5e2
use
jmdembe Jun 30, 2025
3014843
restore find or create agency identity and refactor
jmdembe Jun 30, 2025
07d4b18
re-start build
jmdembe Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/agency_identity_linker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def find_or_create_agency_identity

def create_agency_identity_for_sp
return unless agency_id
AgencyIdentity.create(
AgencyIdentity.create_or_find_by(
agency_id: agency_id,
user_id: @sp_identity.user_id,
uuid: @sp_identity.uuid,
Expand Down
5 changes: 4 additions & 1 deletion spec/services/agency_identity_linker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@

it 'links identities from 2 sps' do
sp1 = create_service_provider_identity(user, 'http://localhost:3000', 'UUID1')
create_service_provider_identity(user, 'urn:gov:gsa:openidconnect:test', 'UUID2')
sp2 = create_service_provider_identity(user, 'urn:gov:gsa:openidconnect:test', 'UUID2')
ai = AgencyIdentityLinker.new(sp1).link_identity
ai2 = AgencyIdentityLinker.new(sp2).link_identity
expect(ai.uuid).to eq('UUID1')
expect(ai2.uuid).to eq('UUID1')

ai = AgencyIdentity.where(user_id: user.id).first
expect(ai.uuid).to eq('UUID1')
end
Expand Down