Skip to content

LG-16305: Update Actual Proofing Rate in DIVR#12248

Merged
solipet merged 1 commit intomainfrom
dprice/lg-16305-divr-update-for-socure
Jun 11, 2025
Merged

LG-16305: Update Actual Proofing Rate in DIVR#12248
solipet merged 1 commit intomainfrom
dprice/lg-16305-divr-update-for-socure

Conversation

@solipet
Copy link
Contributor

@solipet solipet commented Jun 9, 2025

🎫 Ticket

Link to the relevant ticket:
LG-16305

🛠 Summary of changes

The actual proofing rate reported in the DIVR is calculated as the number of successfully verified users divided by the number of users who submit images for doc auth. Previously, this only included users who submit images to TrueID but now that we have started using Socure, we need to include Socure submissions as well.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Log on to a production worker machine and open a rails console
  • Copy/paste the contents of lib/reporting/identity_verification_report.rb into the rails console to update the report code.
  • Run the following code:
cloudwatch_client ||= Reporting::CloudwatchClient.new(
  ensure_complete_logs: true,
  progress: true,
  slice_interval: nil, # if only one day
)

june8 = DateTime.new(2025,6,8,12).all_day

report = Reporting::IdentityVerificationReport.new(
  issuers: nil, # all issuers
  time_range: june8,
  cloudwatch_client: cloudwatch_client,
)
report_data = report.data
puts "Actual Proofing Rate: #{report.actual_proofing_rate}"
  • Compare value to the incorrect value reported in the DIVR from June 8 (i.e., 1.335460061299806)
    Sample output:
identity(prod):482:1* cloudwatch_client ||= Reporting::CloudwatchClient.new(
identity(prod):483:1*   ensure_complete_logs: true,
identity(prod):484:1*   progress: true,
identity(prod):485:1*   slice_interval: nil, # if only one day
identity(prod):486:0> )
identity(prod):487:0>
identity(prod):488:0> june8 = DateTime.new(2025,6,8,12).all_day
identity(prod):489:0>
identity(prod):490:1* report = Reporting::IdentityVerificationReport.new(
identity(prod):491:1*   issuers: nil, # all issuers
identity(prod):492:1*   time_range: june8,
identity(prod):493:1*   cloudwatch_client: cloudwatch_client,
identity(prod):494:0> )
identity(prod):495:0> report_data = report.data
identity(prod):496:0> puts "Actual Proofing Rate: #{report.actual_proofing_rate}"
Querying log slices 100% [1/1] |========================================================================================| Time: 00:00:09
Querying log slices  33% [1/3] |============================                                                            | Time: 00:00:09
...
Querying log slices  92% [71/77] |===============================================================================       | Time: 00:00:09
Querying log slices  93% [72/77] |===============================================================================       | Time: 00:00:09
Querying log slices  93% [72/77] |===============================================================================       | Time: 00:00:09
Querying log slices  94% [73/77] |================================================================================      | Time: 00:00:09
Querying log slices  96% [74/77] |==================================================================================    | Time: 00:00:09
Querying log slices  97% [75/77] |===================================================================================   | Time: 00:00:09
Querying log slices  98% [76/77] |====================================================================================  | Time: 00:00:09
Querying log slices  98% [76/77] |====================================================================================  | Time: 00:00:09
Querying log slices 100% [77/77] |======================================================================================| Time: 00:01:43
Actual Proofing Rate: 0.643789765702741
nil

The actual proofing rate reported in the DIVR is calculated as the
number of successfully verified users divided by the number of users who
submit images for doc auth. Previously, this only included users who
submit images to TrueID but now that we have started using Socure, we
need to include Socure submissions as well.

changelog: Internal, Reporting, Include Socure submissions in actual proofing rate.
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! @AShukla-GSA and I ran through the test plan. Nice work! 👍🏻

Copy link
Contributor

@AShukla-GSA AShukla-GSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@solipet solipet merged commit 7a39904 into main Jun 11, 2025
1 check passed
@solipet solipet deleted the dprice/lg-16305-divr-update-for-socure branch June 11, 2025 22:41
jmdembe pushed a commit that referenced this pull request Jun 12, 2025
The actual proofing rate reported in the DIVR is calculated as the
number of successfully verified users divided by the number of users who
submit images for doc auth. Previously, this only included users who
submit images to TrueID but now that we have started using Socure, we
need to include Socure submissions as well.

changelog: Internal, Reporting, Include Socure submissions in actual proofing rate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants