Conversation
amirbey
force-pushed
the
amirbey/docv-passports-proto
branch
from
17a5837 to
de59477
Compare
amirbey
changed the title
amirbey
force-pushed
the
amirbey/docv-passports-proto
branch
from
3466ada to
201ae50
Compare
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
This PR looks good to me, I think there is one more merge conflict to resolve. I was hoping someone with more context on this could be an extra set of eyes before I approve.
AShukla-GSA
left a comment
AShukla-GSA
left a comment
There was a problem hiding this comment.
Looking good, just confused about some semantics
| end | ||
|
|
||
| def issuing_country_code | ||
| get_data(DATA_PATHS[:issuing_country]) |
There was a problem hiding this comment.
shouldn't this be issuing_country_code. Fits more with the Pii for state ID and passport in app/services
There was a problem hiding this comment.
i'm confused 🤔 ... i see issuing_country_code ... pls explain
There was a problem hiding this comment.
Do you mean the key in DATA_PATHS Abir?
There was a problem hiding this comment.
The key is :issuing_country - see line 18
|
PR looks good!! Thanks for answering my questions, and creating a story for my comment. 👍🏻 |
|
Nice work Amir! Added a comment on the thread Abir created but its non-blocking so I added my approval. |
amirbey
force-pushed
the
amirbey/docv-passports-proto
branch
from
0ebfff0 to
d1b161b
Compare
| end | ||
|
|
||
| def issuing_country_code | ||
| get_data(DATA_PATHS[:issuing_country]) |
There was a problem hiding this comment.
The key is :issuing_country - see line 18
amirbey
force-pushed
the
amirbey/docv-passports-proto
branch
3 times, most recently
from
489c894 to
5595a6d
Compare
amirbey
force-pushed
the
amirbey/docv-passports-proto
branch
from
8cac349 to
ab50d14
Compare
5 participants
🎫 Ticket
LG-16334
🛠 Summary of changes
Allow users to submit a passport to DocV for document authentication
📜 Testing Plan
Feature specs for DocV with passports with pass and fail scenarios