LG-16257 Add email to socure ID plus requests

[shanechesnutt-ft]

🎫 Ticket

Link to the relevant ticket:
LG-16257

🛠 Summary of changes

Add user email address to Socure ID+ and DocumentVerification+ Requests

📜 Testing Plan

• Setup app config to use the sandbox socure environment
• Create an new account
• Complete remote flow reaching the verify phone step
• Login into socure dashboard
• Ensure DocumentVerification Request displays the user email
• Ensure the ID+ request displays the user email
• Ensure no user email is logged during the process

[amirbey]

doesn't seem like we should be removing this nor the comment above .. it's used in this method ... 🤔

[shanechesnutt-ft]

The reason why user_email exists in the proof method is because the threatmetrix_plugin.call method needs a user_email. I removed this from the proof method because I have added the user_email to the constructor and as a class variable. I did this so that I didn't have to pass it through a call chain in order to add it the Proofing::Socure::IdPlus::Config. I see that user_uuid is similar, but was not removed from the proof method before. I am wondering if we should have since it is also in the constructor/class variable.

[Mawar2]

I did notice a potential issue in this file while reviewing - user_email_for_proofing() at line 145 could crash if last_sign_in_email_address returns nil (since it doesn't use safe navigation like your new code in SocureDocvResultsJob does). I know it's pre-existing but flagging it here for a potential future fix.

[Mawar2]

LGTM! ✅

Implementation meets all the acceptance criteria and follows existing patterns in the codebase. Ready to merge.

[amirbey]

LGTM 👍🏿

[solipet]

LGTM!