Skip to content

Lg 16188 update how to verify page#12221

Merged
AShukla-GSA merged 25 commits intomainfrom
lg-16188-update-how-to-verify-page
Jun 10, 2025
Merged

Lg 16188 update how to verify page#12221
AShukla-GSA merged 25 commits intomainfrom
lg-16188-update-how-to-verify-page

Conversation

@AShukla-GSA
Copy link
Contributor

@AShukla-GSA AShukla-GSA commented May 30, 2025

🎫 Ticket

Link to the relevant ticket:
LG-16188

🛠 Summary of changes

Updating hybrid handoff page and updating routing to use hybird handoff as new how to verify in the hybrid (non-mobile) flow.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1 - Go through hybrid flow. On hybrid handoff page ensure new content is in.
  • Step 2 - Go through hybrid flow, on hybird handoff page ensure all links works and all back options take you back to new handoff page.
  • Step 3 - Ensure mobile flow shows no changes

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After:
Non Selfie: Screenshot 2025-05-30 at 11 25 18 AM Screenshot 2025-05-30 at 11 25 38 AM Screenshot 2025-05-30 at 11 25 51 AM Screenshot 2025-05-30 at 11 26 00 AM
Selfie: Screenshot 2025-06-02 at 1 41 59 PM Screenshot 2025-06-02 at 1 42 10 PM Screenshot 2025-06-02 at 1 42 20 PM Screenshot 2025-06-02 at 1 42 28 PM

@anniehirshman-gsa
Copy link
Contributor

Thanks for this! Couple comments on the screenshots:

  • Match spacing above and below the horizontal rule between online and IPP to Figma
  • Illustration up too high on selfie screenshot (non-selfie looks fine)
  • Do the screens have the cancel button and hr?

Happy to test the routing if you have a link to share!

@anniehirshman-gsa
Copy link
Contributor

One more content detail -- these two phrases:

You can use a U.S. passport book, U.S. driver’s license or state ID.

You can only use a U.S. driver’s license or state ID. You cannot use a U.S. passport book for this option.

These should only display if the passports feature flag is enabled, else they should not display. Thanks!

Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍🏻 I have a couple of minor things.

@shanechesnutt-ft
Copy link
Contributor

shanechesnutt-ft commented Jun 4, 2025

Did a little more exploration testing and noticed this scenario. I think it is a separate issue from this PR, but I wanted to document it.

Testing Notes:
Using phone emulation mode with Facial Match Required

  • Navigate to agreement
    • Click continue
  • On the how to verify page
    • Click Continue in person button
  • On the document_capture?step=how_to_verify
    • Click back link
  • On the how to verify page
    • Click Continue on your phone button
      Navigates you to the hybrid handoff (This could be an existing bug)

@anniehirshman-gsa
Copy link
Contributor

Synced to review this and LGTM! Noting that:

  • There are issues with the mobile design of the "Choose how to verify your ID" page outside the scope of this ticket - created LG-16308 to address those inconsistencies
  • If the bug that @shanechesnutt-ft found was not introduced as a part of this ticket, that should also be ticketed. Thanks!

Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting my approval on this I do have one pending comment but I don't think it is a blocker. Nice work Abir!!! 👍🏻

@AShukla-GSA AShukla-GSA force-pushed the lg-16188-update-how-to-verify-page branch 2 times, most recently from 78970ab to 127e832 Compare June 10, 2025 14:21
@AShukla-GSA AShukla-GSA force-pushed the lg-16188-update-how-to-verify-page branch from 127e832 to 437e7dc Compare June 10, 2025 14:42
@AShukla-GSA AShukla-GSA merged commit 967aa13 into main Jun 10, 2025
1 check passed
@AShukla-GSA AShukla-GSA deleted the lg-16188-update-how-to-verify-page branch June 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants