changelog: Upcoming Features, Attempts API, Add idv-ssn-submitted event#12189
Merged
changelog: Upcoming Features, Attempts API, Add idv-ssn-submitted event#12189
Conversation
mitchellhenke
approved these changes
May 19, 2025
Sgtpluck
commented
May 20, 2025
|
|
||
| private | ||
|
|
||
| def consume_params(params) |
Contributor
Author
There was a problem hiding this comment.
it seems like this was a construct developed for forms that are "consuming" a number of different params; while i might argue about whether or not it's that useful generally, it certainly seems like overkill for a form that is only using one param.
Sgtpluck
commented
May 20, 2025
| end | ||
| end | ||
|
|
||
| context 'when the form has invalid attributes' do |
Contributor
Author
There was a problem hiding this comment.
form now cannot accept invalid attributes, so this spec is unnecessary
Sgtpluck
commented
May 20, 2025
| errors:, | ||
| extra: { | ||
| pii_like_keypaths: [ | ||
| [:same_address_as_id], |
Contributor
Author
There was a problem hiding this comment.
is :same_address_as_id necessary here, or is this an artifact of the code doing something else at some point?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
FIE Epic 367
🛠 Summary of changes
this is added in both the usual idv flow and IPP