LG-15980 Add passport info section to verify info form#12181
LG-15980 Add passport info section to verify info form#12181shanechesnutt-ft merged 1 commit intomainfrom
Conversation
dc433ff to
94c5eb6
Compare
82d296f to
5860427
Compare
41700dc to
7e03df3
Compare
ce93294 to
2999a68
Compare
d6b2c1a to
e23d1fe
Compare
|
✅ Ensure Verify Info page matches Figma design |
gina-yamada
left a comment
There was a problem hiding this comment.
I tested with the flags off as well. Working as I'd expect. Nice work Shane!
Thanks for flagging these!
If it's easy to fix the SSN label and spacing to match Figma now, that would be ideal, but keep me posted if it needs more time and a separate ticket. Thanks again!! |
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Screenshot LGTM - with one comment about (preexisting) inconsistencies with Figma that would be great to fix if possible
e23d1fe to
b6ee8dd
Compare
@anniehirshman-gsa I pushed up a fix for those inconsistencies with Figma. I also updated my screenshots with the changes that I have made. |
changelog: Upcoming Features, In-person Proofing, Add passport info section to verify info form
b6ee8dd to
0f612d9
Compare
eileen-nava
left a comment
There was a problem hiding this comment.
I know this is already merged, I just wanted to chime in and say LGTM. 👍🏻
|
|
||
| def enrolled_with_passport_book? | ||
| enrollment.document_type == InPersonEnrollment::DOCUMENT_TYPE_PASSPORT_BOOK | ||
| enrollment.passport_book? |
There was a problem hiding this comment.
👏🏻 This is helpful for clarity.
|
|
||
| let(:ssn_pii) do | ||
| { | ||
| ssn: '666' + Faker::Number.number(digits: 6).to_s, |
There was a problem hiding this comment.
Nice use of a prefix and Faker to ensure the ssn will be recognized as fake. 👍🏻
🎫 Ticket
Link to the relevant ticket:
LG-15980
🛠 Summary of changes
Add passport info section to verify info form
📜 Testing Plan
Scenario: Verify Info page in IPP Passport Flow
Scenario: Verify Info page in IPP State-ID Flow
👀 Screenshots
Verify Info for Passport
Verify Info for State-ID