Irs verification report update

app/jobs/reports/irs_verification_report.rb

@@ -72,7 +72,6 @@ def irs_verification_report
       @irs_verification_report ||= Reporting::IrsVerificationReport.new(
         time_range: previous_week_range,
         issuers: IdentityConfig.store.irs_verification_report_issuers || [],
-        # issuers: ['urn:gov:gsa:openidconnect.profiles:sp:sso:irs:sample'], # Make dynamic
       )
     end
 

lib/reporting/irs_verification_report.rb

@@ -17,10 +17,9 @@ class IrsVerificationReport
     attr_reader :issuers, :time_range
 
     VERIFICATION_DEMAND = 'IdV: doc auth welcome visited'
-    DOCUMENT_AUTHENTICATION_SUCCESS = ['IdV: doc auth image upload vendor pii validation',
-                                       'IdV: doc auth capture_complete visited'].freeze
-    INFORMATION_VALIDATION_SUCCESS = 'IdV: doc auth verify submitted'
-    PHONE_VERIFICATION_SUCCESS = 'IdV: phone confirmation vendor'
+    DOCUMENT_AUTHENTICATION_SUCCESS = 'IdV: doc auth ssn visited'
+    INFORMATION_VALIDATION_SUCCESS = 'IdV: phone of record visited'
+    PHONE_VERIFICATION_SUCCESS = 'idv_enter_password_submitted'
     TOTAL_VERIFIED = 'User registration: complete'
 
     # @param [Array<String>] issuers
@@ -39,6 +38,14 @@ def as_tables
 
     def as_emailable_reports
       [
+        Reporting::EmailableReport.new(
+          title: 'Definitions',
+          subtitle: '',
+          float_as_percent: true,
+          precision: 2,
+          table: data_definition_table,
+          filename: 'Definitions',
+        ),
         Reporting::EmailableReport.new(
           title: 'Overview',
           subtitle: '',
@@ -55,15 +62,6 @@ def as_emailable_reports
           table: funnel_table,
           filename: 'Funnel Metrics',
         ),
-        Reporting::EmailableReport.new(
-          title: 'Metrics Definitions',
-          subtitle: '',
-          float_as_percent: true,
-          precision: 2,
-          table: data_definition_table,
-          filename: 'Metric Definitions',
-        ),
-
       ]
     end
 

spec/lib/reporting/irs_verification_report_spec.rb

@@ -21,17 +21,19 @@ def previous_week_range
 
   describe '#overview_table' do
     it 'generates the overview table with the correct data' do
-      # Dynamically calculate the expected "Report Generated" date
-      expected_generated_date = Time.zone.today.to_date.to_s
-      # Adjust this logic if the method uses a different approach
+      # Mock the current date to ensure consistency
+      travel_to Date.new(2025, 5, 14) do
+        # Use Time.zone.today for time zone consistency
+        expected_generated_date = '2025-05-14'
 
-      table = report.overview_table
+        table = report.overview_table
 
-      expect(table).to include(
-        ['Report Timeframe', "#{time_range.begin.to_date} to #{time_range.end.to_date}"],
-        ['Report Generated', expected_generated_date], # Dynamically match the generated date
-        ['Issuer', issuers.join(', ')],
-      )
+        expect(table).to include(
+          ['Report Timeframe', "#{time_range.begin.to_date} to #{time_range.end.to_date}"],
+          ['Report Generated', expected_generated_date], # Dynamically match the generated date
+          ['Issuer', issuers.join(', ')],
+        )
+      end
     end
   end
 
@@ -63,9 +65,17 @@ def previous_week_range
 
       expect(csvs).to be_an(Array)
       expect(csvs.size).to eq(3) # One for each table
-      expect(csvs.first).to include('Report Timeframe')
-      expect(csvs[1]).to include('Metric,Count,Rate')
-      expect(csvs.last).to include('Metric,Definition')
+
+      # First CSV: Definitions
+      expect(csvs.first).to include('Metric,Definition')
+
+      # Second CSV: Overview table
+      expect(csvs[1]).to include('Report Timeframe')
+      expect(csvs[1]).to include('Report Generated')
+      expect(csvs[1]).to include('Issuer')
+
+      # Third CSV: Funnel table
+      expect(csvs.last).to include('Metric,Count,Rate')
     end
   end
 end

spec/mailers/previews/report_mailer_preview.rb

@@ -166,7 +166,7 @@ def irs_verification_report
       email: 'test@example.com',
       subject: "Example IRS Verification Report - #{Time.zone.now.to_date}",
       message: "Report: IRS Verification Report -  #{Time.zone.now.to_date}",
-      attachment_format: :xlsx,
+      attachment_format: :csv,
       reports: irs_verification_report.reports,
     )
   end