Skip to content

Add IPP event#12093

Merged
Sgtpluck merged 2 commits intomainfrom
dmm/ipp-event
Apr 22, 2025
Merged

Add IPP event#12093
Sgtpluck merged 2 commits intomainfrom
dmm/ipp-event

Conversation

@Sgtpluck
Copy link
Copy Markdown
Contributor

🎫 Ticket

Link to the relevant ticket:
163

🛠 Summary of changes

This is an event that did not exist in the initial implementation of the Attempts API. It is capturing the "Transfer to Supervised Remote Process" milestone.

This change:

  • adds the event
  • adds tests
  • also updates the event description, which was incorrect

@Sgtpluck Sgtpluck requested review from a team and mitchellhenke April 21, 2025 19:20
)
end

# A user is transferred to the in-person proofing workflow
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this comment be more specific? Maybe, A user completes the online portion of the in-person proofing process or A user becomes able to visit the post office for in-person proofing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 23872c5

@@ -1,5 +1,5 @@
description: |
When the user submits the security code that they received on their phone to verify their phone or address during identity proofing.
When the user transfers to the in-person proofing workflow.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend updating this comment to clarify that the user is already in the in-person proofing process when they visit the IPP ready to verify page.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 23872c5

Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. 👍🏻

@Sgtpluck Sgtpluck merged commit 35168fd into main Apr 22, 2025
1 check passed
@Sgtpluck Sgtpluck deleted the dmm/ipp-event branch April 22, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants