Skip to content

LG-15837: Turn-on F/T unlock to SMS users - using security messaging variant#12086

Merged
jmdembe merged 16 commits intomainfrom
jd/LG-15837-security-messaging
Apr 23, 2025
Merged

LG-15837: Turn-on F/T unlock to SMS users - using security messaging variant#12086
jmdembe merged 16 commits intomainfrom
jd/LG-15837-security-messaging

Conversation

@jmdembe
Copy link
Copy Markdown
Contributor

@jmdembe jmdembe commented Apr 17, 2025

🎫 Ticket

LG-15837: Turn-on F/T unlock to SMS users - using security messaging variant

🛠 Summary of changes

This PR adds the face/touch unlock upsell for users who setting up their account with SMS to also add face/touch unlock to their account for better security

📜 Testing Plan

Prerequisite: a mobile device. This can be simulated in the browser by right click -> Inspect -> and then changing the dimensions to a phone

  • Follow steps to create an account
  • Once on "Authentication method setup" screen, check "Text or voice message"
  • Follow steps to add phone to your account. Make sure that Text message (SMS) is selected
  • Follow steps to complete setup
  • Land on "Set up face or touch unlock for a more secure sign in"

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

English Spanish French Chinese
Screenshot of set up face or touch unlock for a more secure sign in in English Screenshot of set up face or touch unlock for a more secure sign in in Spanish Screenshot of set up face or touch unlock for a more secure sign in in French Screenshot of set up face or touch unlock for a more secure sign in in French

@jmdembe jmdembe requested a review from a team April 22, 2025 17:47
@jmdembe jmdembe marked this pull request as ready for review April 22, 2025 17:47
@jmdembe jmdembe changed the title DRAFT: Turn-on F/T unlock to SMS users - using security messaging variant LG-15837: Turn-on F/T unlock to SMS users - using security messaging variant Apr 22, 2025
Copy link
Copy Markdown
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. I tested locally and it behaved as expected.

@jmdembe jmdembe merged commit 645d90f into main Apr 23, 2025
1 check passed
@jmdembe jmdembe deleted the jd/LG-15837-security-messaging branch April 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants