Skip to content

LG-15970 Add choose id type page to ID-IPP flow#12084

Merged
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-15970
Apr 21, 2025
Merged

LG-15970 Add choose id type page to ID-IPP flow#12084
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-15970

Conversation

@shanechesnutt-ft
Copy link
Copy Markdown
Contributor

@shanechesnutt-ft shanechesnutt-ft commented Apr 17, 2025

🎫 Ticket

Link to the relevant ticket:
LG-15970

🛠 Summary of changes

Add choose ID type to ID-IPP passport flow and integration tests.

📜 Testing Plan

Ensure hybrid flow is checked

Scenario: Global passports and In-Person Passports is enabled
Setup: Ensure the following environment variables are set

  in_person_proofing_enabled: true
  in_person_proofing_opt_in_enabled: true
  in_person_passports_enabled: true
  doc_auth_passports_enabled: true
  doc_auth_passports_percent: 100
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the post office selection page
  • Select a post office
  • Ensure user is navigated to the choose ID type page

Scenario: Global passports are enabled and in-person passports is disabled

  in_person_proofing_enabled: true
  in_person_proofing_opt_in_enabled: true
  in_person_passports_enabled: false
  doc_auth_passports_enabled: true
  doc_auth_passports_percent: 100
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the post office selection page
  • Select a post office
  • Ensure user is navigated to the state ID page

Scenario: Global passports are disabled and in-person passports is enabled

  in_person_proofing_enabled: true
  in_person_proofing_opt_in_enabled: true
  in_person_passports_enabled: true
  doc_auth_passports_enabled: false
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the post office selection page
  • Select a post office
  • Ensure user is navigated to the state ID page

Screenshots

Screenshot 2025-04-21 at 3 11 28 PM

@rutvigupta-design
Copy link
Copy Markdown

@shanechesnutt-ft I'm noticing the text in the beginning seems to be in line with the remote flow's content instead of IPP. I think it should say "Select the type of document that you want to use. You’ll need to bring this document to the Post Office." instead of what is showing up in the screenshot.

@gina-yamada
Copy link
Copy Markdown
Contributor

gina-yamada commented Apr 17, 2025

Scenario: Global passports and In-Person Passports is enabled
✅ Opt-in to IPP - Choose ID Type View after Post Office Selection, AWS Event logs new event and accurate info - ie: opted_in_to_in_person_proofing = true
✅ Failed Remote - Choose ID Type View after Post Office Selection, AWS Event logs new event and accurate info- ie: opted_in_to_in_person_proofing = false)
✅ Hybrid -> failed remote -> moved into IPP - I was kicked back to /verify/in_person/choose_id_type as I'd expect after picking a PO on mobile. AWS Events logs new event and accurate info - ie: flow path is hybrid, correct step, opted in to IPP is false

Scenario: Global passports are enabled and in-person passports is disabled
✅ Opt-in to IPP- Navigated to State ID after Post Office Selection, AWS event logs State Id visited
✅ Failed Remote - Navigated to State ID after Post Office Selection, AWS event logs State Id visited
✅ Hybrid -> failed remote -> moved into IPP - Was kicked back to State ID (desktop) after Post Office Selection (mobile), AWS event logs State Id visited

Scenario: Global passports are disabled and in-person passports is enabled
✅ Opt-in to IPP- Navigated to State ID after Post Office Selection, AWS event logs State Id visited
✅ Failed Remote - Navigated to State ID after Post Office Selection, AWS event logs State Id visited
✅ Hybrid -> failed remote -> moved into IPP - Was kicked back to State ID (desktop) after Post Office Selection (mobile), AWS event logs State Id visited

Summary
✅ As noted above for each scenario, page navigation from Post Office selection to next page is working as expected
✅ As noted above for each scenario, new AWS logs when expected with correct data
✅ Page is translated (out of scope but complete)
✅ Page is responsive
✅ New route/controller for IPP
✅ Cancel is working as expected. AWS Cancel Event logs accurate step and request came from correctly. No, keep going returns to /verify/in_person/choose_id_type as I'd expect and Start over navigates me to /verify/welcome as I'd expect.
✅ AWS Analytic Event Testing - update - added flag inside feature specs
✅ The header is for remote. UPDATE- This is resolved
✅ Already mentioned, content needs to be updated UPDATE- This is resolved

Header I see...

Screenshot 2025-04-18 at 10 22 00 AM

Header I'd expect...

Screenshot 2025-04-18 at 10 19 54 AM

@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-15970 branch 3 times, most recently from f25d27a to 24fc427 Compare April 21, 2025 15:44
@gina-yamada gina-yamada self-requested a review April 21, 2025 15:56
@rutvigupta-design
Copy link
Copy Markdown

@shanechesnutt-ft thanks for making the UI changes, this is looking great! 🎉 Few minor nits:

  • The screenshot says "Select the type of document that you have." but the design says "Select the type of document that you want to use." Could we please change the content to match the design?
  • Could you please confirm that the spacing between the second radio button and the 'Continue' button is 32 px/2 rem? This might be just my eyes but it's looking a little more than 32 px so just wanted to confirm!

@gina-yamada gina-yamada self-requested a review April 21, 2025 17:01
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think design's comments need to be addressed before this is merged, but I am happy with this from an engineering perspective. Good work!

end

context 'with in person proofing enabled for service provider' do
context 'when in person passports are allowed' do
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the thorough test coverage here.

end

describe '#update' do
context 'when the issuer has IPP enabled' do
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for referring to the issuer rather than the service provider?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think I just missed updating that... I fixed it

@@ -0,0 +1,15 @@
# frozen_string_literal: true

class Idv::InPerson::ChooseIdTypePresenter < Idv::ChooseIdTypePresenter
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of inheritance. 👍🏻

Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved- you addressed all of my comments. Nice work Shane! 👏

Confirmed Presenters (diff content & step indicator) are working as expected for Doc Auth, IPP, and hybrid (see url)

Screenshot 2025-04-21 at 11 10 25 AM

Screenshot 2025-04-21 at 11 10 47 AM

Screenshot 2025-04-21 at 11 12 55 AM

@shanechesnutt-ft
Copy link
Copy Markdown
Contributor Author

Tagging @anniehirshman-gsa since we have made a small spacing change between the radio button and the continue button on the choose_id_type form. This change will affect the hybrid and remote flow.

Screenshot 2025-04-21 at 3 14 27 PM Screenshot 2025-04-21 at 3 15 35 PM

@rutvigupta-design
Copy link
Copy Markdown

This looks great @shanechesnutt-ft - reviewed and approved by Joy design! 🎉

Copy link
Copy Markdown
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirmed no regression on the remote IdV choose your ID type screen.

changelog: Upcoming Features, In-person proofing, Add choose ID type to ID-IPP passport flow
Copy link
Copy Markdown
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested it on the remote proofing side and it still works correctly

@shanechesnutt-ft shanechesnutt-ft merged commit 2f99eca into main Apr 21, 2025
1 check passed
@shanechesnutt-ft shanechesnutt-ft deleted the sc/LG-15970 branch April 21, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants