LG-15970 Add choose id type page to ID-IPP flow#12084
Conversation
e2f167c to
e6f8806
Compare
|
@shanechesnutt-ft I'm noticing the text in the beginning seems to be in line with the remote flow's content instead of IPP. I think it should say "Select the type of document that you want to use. You’ll need to bring this document to the Post Office." instead of what is showing up in the screenshot. |
spec/controllers/idv/in_person/choose_id_type_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/idv/in_person/choose_id_type_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/idv/in_person/choose_id_type_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/idv/in_person/choose_id_type_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/idv/in_person/choose_id_type_controller_spec.rb
Outdated
Show resolved
Hide resolved
f25d27a to
24fc427
Compare
|
@shanechesnutt-ft thanks for making the UI changes, this is looking great! 🎉 Few minor nits:
|
eileen-nava
left a comment
There was a problem hiding this comment.
Approved. I think design's comments need to be addressed before this is merged, but I am happy with this from an engineering perspective. Good work!
| end | ||
|
|
||
| context 'with in person proofing enabled for service provider' do | ||
| context 'when in person passports are allowed' do |
There was a problem hiding this comment.
I appreciate the thorough test coverage here.
| end | ||
|
|
||
| describe '#update' do | ||
| context 'when the issuer has IPP enabled' do |
There was a problem hiding this comment.
What's the motivation for referring to the issuer rather than the service provider?
There was a problem hiding this comment.
Yeah I think I just missed updating that... I fixed it
| @@ -0,0 +1,15 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Idv::InPerson::ChooseIdTypePresenter < Idv::ChooseIdTypePresenter | |||
There was a problem hiding this comment.
Nice use of inheritance. 👍🏻
|
Tagging @anniehirshman-gsa since we have made a small spacing change between the radio button and the continue button on the choose_id_type form. This change will affect the hybrid and remote flow.
|
|
This looks great @shanechesnutt-ft - reviewed and approved by Joy design! 🎉 |
changelog: Upcoming Features, In-person proofing, Add choose ID type to ID-IPP passport flow
2ecac52 to
8426f3e
Compare
theabrad
left a comment
There was a problem hiding this comment.
LGTM tested it on the remote proofing side and it still works correctly







🎫 Ticket
Link to the relevant ticket:
LG-15970
🛠 Summary of changes
Add choose ID type to ID-IPP passport flow and integration tests.
📜 Testing Plan
Ensure hybrid flow is checked
Scenario: Global passports and In-Person Passports is enabled
Setup: Ensure the following environment variables are set
Scenario: Global passports are enabled and in-person passports is disabled
Scenario: Global passports are disabled and in-person passports is enabled
Screenshots