Skip to content

Lg-16000 implement vendor outage error for dos api#12073

Merged
AShukla-GSA merged 10 commits intomainfrom
lg-16000-implement-vendor-outage-error-for-dos-api
Apr 23, 2025
Merged

Lg-16000 implement vendor outage error for dos api#12073
AShukla-GSA merged 10 commits intomainfrom
lg-16000-implement-vendor-outage-error-for-dos-api

Conversation

@AShukla-GSA
Copy link
Copy Markdown
Contributor

@AShukla-GSA AShukla-GSA commented Apr 14, 2025

🎫 Ticket

Link to the relevant ticket:
LG-16000

🛠 Summary of changes

Call health check api on choose id type screen, disable passport option and show alert text described in ticket.

📜 Testing Plan

Provide a checklist of steps to confirm the changes. Test process involves editing application.yml halfway through a idv flow. The reason for this is to let the health check pass for the welcome controller and fail for the choose id type controllers (tested on the specs)

  • Step 1 - Ensure specs pass and test functionality
    Next steps for manual testing
  • Step 2 - For manual testing, Set following

doc_auth_passports_enabled: true
doc_auth_passports_percent: 100

  • Step 3 - Go through Doc Auth (Hybrid and standard). Once on the hybrid handoff page (or before selecting upload photos on standard), set dos_passport_composite_healthcheck_endpoint to a dummy value (Ex: "http://localhost:3000/healthcheck")
  • Step 4 - KEEP PAGE OPEN and refresh rails server, stop server and re run make run.
  • Step 5 - Continue doc auth (either link sent or upload photos).
  • Step 6 - Once on choose id type screen confirm passport option is disabled and alert text is shown.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After: Screenshot 2025-04-22 at 9 23 28 AM Screenshot 2025-04-22 at 9 23 48 AM Screenshot 2025-04-22 at 9 24 10 AM Screenshot 2025-04-22 at 9 24 29 AM Screenshot 2025-04-22 at 9 27 20 AM Screenshot 2025-04-22 at 9 27 51 AM Screenshot 2025-04-22 at 9 28 20 AM Screenshot 2025-04-22 at 9 28 48 AM

@amirbey
Copy link
Copy Markdown
Contributor

amirbey commented Apr 21, 2025

LGTM @AShukla-GSA 👍🏿 ... it looks like the Figma selects state ID by default when API is down? 🤔

@AShukla-GSA AShukla-GSA force-pushed the lg-16000-implement-vendor-outage-error-for-dos-api branch from d022f02 to 505dc2a Compare April 22, 2025 14:41
Copy link
Copy Markdown
Contributor

@amirbey amirbey Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AShukla-GSA - should we use the real value here? and also provide the default when down?

fysa ... 👀 @gina-yamada @shanechesnutt-ft

@amirbey amirbey self-requested a review April 22, 2025 21:28
Copy link
Copy Markdown
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .. thanks @AShukla-GSA

@AShukla-GSA AShukla-GSA force-pushed the lg-16000-implement-vendor-outage-error-for-dos-api branch from b4a3a0e to d45f69e Compare April 23, 2025 14:30
@AShukla-GSA AShukla-GSA merged commit 9f188f5 into main Apr 23, 2025
1 check passed
@AShukla-GSA AShukla-GSA deleted the lg-16000-implement-vendor-outage-error-for-dos-api branch April 23, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants