Lg-16000 implement vendor outage error for dos api#12073
Merged
AShukla-GSA merged 10 commits intomainfrom Apr 23, 2025
Merged
Conversation
Contributor
|
LGTM @AShukla-GSA 👍🏿 ... it looks like the Figma selects state ID by default when API is down? 🤔 |
d022f02 to
505dc2a
Compare
amirbey
reviewed
Apr 22, 2025
Contributor
There was a problem hiding this comment.
@AShukla-GSA - should we use the real value here? and also provide the default when down?
fysa ... 👀 @gina-yamada @shanechesnutt-ft
amirbey
reviewed
Apr 22, 2025
amirbey
approved these changes
Apr 22, 2025
Contributor
amirbey
left a comment
There was a problem hiding this comment.
LGTM .. thanks @AShukla-GSA
amirbey
reviewed
Apr 22, 2025
amirbey
reviewed
Apr 22, 2025
amirbey
reviewed
Apr 22, 2025
amirbey
reviewed
Apr 22, 2025
amirbey
reviewed
Apr 23, 2025
amirbey
reviewed
Apr 23, 2025
…choose id type screen
b4a3a0e to
d45f69e
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-16000
🛠 Summary of changes
Call health check api on choose id type screen, disable passport option and show alert text described in ticket.
📜 Testing Plan
Provide a checklist of steps to confirm the changes. Test process involves editing
application.ymlhalfway through a idv flow. The reason for this is to let the health check pass for the welcome controller and fail for the choose id type controllers (tested on the specs)Next steps for manual testing
dos_passport_composite_healthcheck_endpointto a dummy value (Ex:"http://localhost:3000/healthcheck")make run.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
After: