LG-15437: New 'Add a photo of your passport' screen#12061
Conversation
solipet
force-pushed
the
dprice/lg-15437-doc-cap-passport
branch
from
f1b2fe0 to
7b22c5f
Compare
solipet
requested review from
AShukla-GSA,
amirbey,
anniehirshman-gsa,
jmax-gsa and
theabrad
app/javascript/packages/document-capture/interface/documents-image-selfie-value.tsx
Show resolved
Hide resolved
app/javascript/packages/document-capture/interface/documents-image-selfie-value.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Caveat: I'm still learning the frontend piece of the doc auth flow
This mostly looks good!
One outstanding question I have is how does the new document capture step get represented in the analytics?
There weren't any additions or changes in analytics_events.rb to support tracking the same events that are logged for front and back image capture.
|
Mobile should follow this design and content (looks different than the state ID page on mobile). And the old yellow banner on hybrid can be removed from the "Add a photo of your passport" page because it appears on the previous page ("Choose your ID type"). Happy to test again when ready. Desktop LGTM thanks! |
A new 'step' for document capture for capturing a picture of a user's passport book. changelog: Upcoming Features, Passports, Document capture screen for passport books. Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
…rs licence capture.
Co-authored-by: Alex Bradley <alex.bradley@gsa.gov> Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
solipet
force-pushed
the
dprice/lg-15437-doc-cap-passport
branch
from
bbeeb01 to
f473496
Compare
app/controllers/idv/hybrid_mobile/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/acuant-capture.tsx
Outdated
Show resolved
Hide resolved
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
Tested it on desktop worked as intended.
Tested on mobile, the only problem I see is when you load the acuant camera and turn your phone sideways to take the picture, the camera does not take up the full screen, I can still see the browser bar and tabs on safari
|
I tested on mobile (Chrome) and desktop and worked as expected 👍🏿 |
AShukla-GSA
left a comment
AShukla-GSA
left a comment
There was a problem hiding this comment.
Tested and confirmed on Safari. LGTM!
7 participants
🎫 Ticket
Link to the relevant ticket:
LG-15437
LG-16092
🛠 Summary of changes
New passport capture page in the document capture react app.
📜 Testing Plan
Can run locally or use the solipet env.
Note
Submitting will currently fail and take you to the try again screen for state ID capture. This will be updated in a later ticket.
👀 Screenshots
Screenshot, in all languages:
en:
es:
fr:
zh:
preview: