LG-15859 Add service provider name to barcode deadline alert

[shanechesnutt-ft]

🎫 Ticket

Link to the relevant ticket:
LG-15859

🛠 Summary of changes

Add service provider name to the barcode deadline alert for the email and app view.

📜 Testing Plan

Check Emails

• Ready to Verify ID-IPP
  • English
  • Spanish
  • French
  • Chinese
• Ready to Verify EIPP
  • English
  • Spanish
  • French
  • Chinese
• Ready to Verify Reminder ID-IPP
  • English
  • Spanish
  • French
  • Chinese
• Ready to Verify Reminder EIPP
  • English
  • Spanish
  • French
  • Chinese

Scenario: User creates a pending enrollment

• Login through the oidc sinatra application selecting the Identity Verified level of service.
• Create a new account
• Complete the ID-IPP flow reaching the ready to verify page.
• Ensure the sentence "Complete this step to access {service provider name}." is present on the page in the blue deadline alert for each supported language
  • English
  • Spanish
  • French
  • Chinese

👀 Screenshots

Ready to Verify Email

Language	Screenshot
English
Spanish
French
Chinese

Ready to Verify Reminder Email

Language	Screenshot
English
Spanish
French
Chinese

Ready to Verify Page

Language	Screenshot
English
Spanish
French
Chinese

[eileen-nava]

Did you get a chance to look at the data in prod and see if any service providers don't have a friendly_name populated? (This isn't a blocking concern, just something I was wondering about after we discussed it.)

[shanechesnutt-ft]

I have not looked at prod

[eileen-nava]

Looks good to me. Approved.

[gina-yamada]

✅ Followed testing plan. I can see additional sentence on Ready to Verify Email and Ready to Verify View for IPP, EIPP, and the Reminder for both. (I went through IPP and EIPP flow and checked rails mailers)
✅ Translations added to correct language file. Translations look accurate and punctuations was included as from translation file.
✅ Specs added to reflect change
✅ Additional test locally not coming in from Sinatra- Login.gov is the SP displayed. (I had to type in the URL to move into the flow. A typical user would not move forward.) This should be okay but worth a quick check before merging. You also mentioned @presenter.sp_name is already used in the view so should always be present else I would have suspected this would have been reported broken.

Nice work @shanechesnutt-ft 👏 🎩 🪶 🚀

[kellular]

This LGTM from UX