Skip to content

Remove all use of sp_return_logs.requested_at#12010

Merged
vrajmohan merged 1 commit intomainfrom
vm-remove-requested-at-from-sp-return-log-2
Mar 25, 2025
Merged

Remove all use of sp_return_logs.requested_at#12010
vrajmohan merged 1 commit intomainfrom
vm-remove-requested-at-from-sp-return-log-2

Conversation

@vrajmohan
Copy link
Copy Markdown
Contributor

changelog: Internal, Events, Remove all use of sp_return_logs.requested_at

Step 2 of 3

Steps:

  1. Add migration to drop the NOT NULL constraint and deploy
  2. Add column to ignored_columns, remove all reads and writes and deploy
  3. Drop column using safety_assured and deploy

🎫 Ticket

Link to the relevant ticket:
LG-13781

@vrajmohan vrajmohan requested a review from a team March 21, 2025 16:38
@vrajmohan vrajmohan force-pushed the vm-remove-requested-at-from-sp-return-log-2 branch from 941340e to 1f647c1 Compare March 21, 2025 17:38
changelog: Internal, Events, Remove all use of sp_return_logs.requested_at

Step 2 of 3

Steps:
1. Add migration to drop the NOT NULL constraint and deploy
2. Add column to `ignored_columns`, remove all reads and writes and deploy
3. Drop column using `safety_assured` and deploy
@vrajmohan vrajmohan force-pushed the vm-remove-requested-at-from-sp-return-log-2 branch from 1f647c1 to 893cc3a Compare March 21, 2025 18:06
@vrajmohan vrajmohan marked this pull request as ready for review March 21, 2025 19:53
Copy link
Copy Markdown
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@vrajmohan vrajmohan merged commit 1c793a2 into main Mar 25, 2025
2 checks passed
@vrajmohan vrajmohan deleted the vm-remove-requested-at-from-sp-return-log-2 branch March 25, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants