Skip to content

LG-15691 Validate passport mrz#11978

Merged
jmax-gsa merged 5 commits intomainfrom
jmax/LG-15691-validate-passport-mrz
Apr 7, 2025
Merged

LG-15691 Validate passport mrz#11978
jmax-gsa merged 5 commits intomainfrom
jmax/LG-15691-validate-passport-mrz

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Mar 13, 2025

🎫 Ticket

Link to the relevant ticket:
LG-15691

🛠 Summary of changes

Added Passport MRZ validation via the DoS API to our Lexis Nexis flow

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Verify by inspection that the new tests in api_image_upload_form_spec.rb check the desired functionality
  • Verify that all specs including the new ones pass without error.

(End-to-end testing will be performed for the entire feature once all sub-tasks are complete).

@jmax-gsa jmax-gsa force-pushed the jmax/LG-15691-validate-passport-mrz branch 6 times, most recently from b8219cc to d6b2b7e Compare March 19, 2025 16:38
@jmax-gsa jmax-gsa marked this pull request as ready for review March 19, 2025 16:38
@jmax-gsa jmax-gsa force-pushed the jmax/LG-15691-validate-passport-mrz branch 2 times, most recently from 07ae603 to 5f7f7c8 Compare March 19, 2025 17:10
Copy link
Contributor

@AShukla-GSA AShukla-GSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmax-gsa jmax-gsa requested a review from amirbey March 26, 2025 14:58
jmax-gsa added 2 commits April 2, 2025 10:32
Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>

Update app/forms/idv/api_image_upload_form.rb

Lint.
@jmax-gsa jmax-gsa force-pushed the jmax/LG-15691-validate-passport-mrz branch from 437486a to a9f4d07 Compare April 2, 2025 16:49
Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... thanks @jmax-gsa

@jmax-gsa jmax-gsa merged commit 85dbaae into main Apr 7, 2025
1 check passed
@jmax-gsa jmax-gsa deleted the jmax/LG-15691-validate-passport-mrz branch April 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants