Merged
Conversation
* Avoid orphaned punctuation using non-breaking whitespace changelog: User-Facing Improvements, Content Legibility, Avoid orphaned punctuation using non-breaking whitespace * Inline lock icon rendering in banner
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.20 to 1.12.4. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/commits/v1.12.4) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2) (#11926) * LG-15655: Submit reCAPTCHA annotations through worker job changelog: Internal, Anti-Fraud Tooling, Submit reCAPTCHA annotations through worker job * Remove feature flag for annotating sign-in reCAPTCHA * Remove redundant specs Already tested with coverage on RecaptchaAnnotator#submit_assessment * Destroy assessment record after submission * Revert unintended spec changes for RecaptchaAnnotator Originally considered approach deleting the record inside the annotator class * Delete assessment as part of annotator * Add timestamps to recaptcha_assessments
…1930) * LG-15833: Maintain partner link when session times out at sign-in changelog: Bug Fixes, Sign-In, Maintain partner link when session times out at sign-in * Change session timeout config unit to seconds Why: 1. To simplify stubbing tests to simulate very short session timeout (e.g. 1 second) to avoid delays in tests waiting 2. For alignment with related `session_timeout_warning_seconds` config 3. To allow more granular control over session durations * Add test coverage for partner request after session expires * Stub url_for in view spec * Ensure minutes conversion uses integer value * Prevent link behavior in session timeout pack * Always redirect expired session to sign-in page e.g. they might be partially signed-in at the MFA step, but in that case we'd still want to bring them back to the sign-in page, since the SessionsController is where the request_id is maintained * Update button expectation for signed-in session timeout * Try waiting for content instead of modal * Stub Devise timeout This should be assigned through session_timeout_in_seconds, but it may already be cached by the time we've assigned the stub on IdentityConfig
* Add idv_level to ProfileSummary report changelog: Internal, Reporting, Add idv_level to ProfileSummary report * Update spec/lib/data_pull_spec.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* changelog: Internal, Lexis Nexis Request, add uuid to threatmetrix job * change to user_uuid * remove unused method check
…ently (#11899) * add update interval to info on otp expirateion screen * add class and value for screen reader frequency * remove update frequency changelog: Bug fixes, accessibility, slow down countdown frequency * use store value instead of hardcoded number * update documentation and test setup * add test for new class * first round of lintfixes for tests * udo changes * trying with the countdown component in screen reader container * clean up syntax * change start immediately * WIP: lintfix and creating untested modal * clean up readme file * more changes to alerts * positive step: turn `aria-live` to off when alert appears so that we have space for countdown * lintfix: remove console.log * remove more `screenReaderFrequency`, try putting an attribute to delay countdown * lintfixes * add class to denote delay? * add class to denote delay? * remove `tag_options` because that did not work * remove `delay_countdown_announcement`, change `<p>` to '<div>' tags * add new class, function with comment on where to go next * remove added classes again, make change to countdown element * lintfix * add modifier to time so that screenreader time and visible time are synced to announce. * make update to try and get `show_at_remaining` to sync with visible banner * rename configuration and `console.log` * remove config because it does not need to be hard coded * a11y test fix * address code review comments * address unused helper and `>` in html * Update app/components/countdown_component.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * test to show that can be overriden --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
mdiarra3
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal