LG-15698 Cancel Pervious In-Person Enrollments at start

[gina-yamada]

🎫 Ticket

Link to the relevant ticket:
LG-15698 Clean up establishing in person enrollments when the user abandons their session

🛠 Summary of changes

• On welcome, rather than cancelling previous in person enrollments on update I moved this to occur in a before action. This prevents a user from moving from /verify/welcome to /verify/in_person/state_id by typing in the url because they no longer have an existing establishing enrollment. (We were cleaning up previous enrollments just after Welcome but now we will do it before

📜 Testing Plan

• Step 1 Login through the oidc sinatra application selecting the Identity Verified level of service
• Step 2 Create a new account
• Step 3 Start the ID-IPP flow. Pick a Post Office. Complete steps State ID, Address, SSN, and Verify your Information
• Step 4 Once on Verify your phone number clear your cookies to simulate your session timed out/expired
• Step 5 Sign in through Sinatra
• Step 6 Confirm you are on the Welcome page
• Step 7 Manually type /verify/in_person/state_id in the url and hit enter
• Step 8 Confirm you should remain on the Welcome page (and you are not taken to the state id page)
• Step 9 Confirm you do not have an establishing enrollment
• Step 10 Ensure you can move through IPP to create an enrollment (after steps 1-9)
• Step 11 Ensure you can move through Remote flow and verify your identity (after steps 1-9)
• Step 12 Repeat steps 1-10. Sign out. Sign in via Sinatra. Ensure that you have a pending In-person enrollment and that when you sign back in, you are directed to Ready to Verify [barcode view] and that your enrollment is not cancelled
• Step 13 Repeat steps 1-10. Sign out. Sign in via Sinatra. Ensure that if you have an in fraud review In-person enrollment and that you are taken to the please call screen when you sign back in, and that your enrollment is not cancelled

[gina-yamada]

I deleted this logic. I cannot think of a case where we'd not want to clean up in person enrollments. Let me know your opinions on this.

ie: If a user got as far as to create an establishing enrollment and then let their session expire, started again... and then if we turned IPP off for an outage during this time, I feel we'd still want to clean up the previous enrollment even if they cannot move through IPP again.

[eileen-nava]

This makes sense to me!

[gina-yamada]

@shanechesnutt-ft I added one additional spec since you pulled down. Just an fyi

[shanechesnutt-ft]

Ran through the test cases and things look good to me! Good Job! 👍🏻