Skip to content

Restore line break for partner email selection#11914

Merged
aduth merged 1 commit intomainfrom
aduth-connected-email-line-break
Feb 25, 2025
Merged

Restore line break for partner email selection#11914
aduth merged 1 commit intomainfrom
aduth-connected-email-line-break

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Feb 25, 2025

🛠 Summary of changes

Updates layout of partner email selection screen to include a line break between "connected with:" line and the selected email, per the original design. This regressed in recent changes. It particularly affects cases where the user has not yet selected an email to be shared with the partner application.

📜 Testing Plan

Disable partner email selection feature before starting, in config/application.yml:

development:
  feature_select_email_to_share_enabled: false
  1. Have sample application running in a separate process
  2. Go to http://localhost:9292
  3. Click "Sign in"
  4. Create an account
  5. Once returned to the partner, visit http://localhost:3000
  6. Go to "Your connected accounts" page in account dashboard
  7. Re-enable partner email selection feature by removing the config/application.yml added above, and restarting the local server
  8. Refresh the "Your connected accounts" page
  9. Verify "Email not yet selected" appears on its own line with "Change"

👀 Screenshots

Before After
Screenshot 2025-02-25 at 8 07 37 AM Screenshot 2025-02-25 at 8 07 43 AM

@aduth aduth requested review from a team and jmdembe February 25, 2025 13:13
@aduth aduth merged commit df39e31 into main Feb 25, 2025
2 checks passed
@aduth aduth deleted the aduth-connected-email-line-break branch February 25, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants