LG-15803: Include all arguments in A/B report base job class initialization#11913
Merged
LG-15803: Include all arguments in A/B report base job class initialization#11913
Conversation
[skip changelog]
kevinsmaster5
approved these changes
Feb 24, 2025
Contributor
kevinsmaster5
left a comment
There was a problem hiding this comment.
LGTM! 👍
Great find.
Contributor
Author
Testing this locally, it's a little harder to verify than I anticipated, because the error isn't output to the terminal. But you can find (or not find, after these changes) the Something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15803
🛠 Summary of changes
Fixes an error where the recurring job for A/B test reporting doesn't complete because the
performmethod doesn't receive all arguments.The underlying issue is that the
supercall did not pass all of the original position arguments received by the call, so the job did not have the arguments to send to the enqueuedperform(ref).📜 Testing Plan
You could also locally modify the job configuration to either use a shorter
cronvalue, or modify thecron_24hvalue to occur on a quicker cadence, and then ensure that the job does not error when run viabundle exec good_job start.