-
Notifications
You must be signed in to change notification settings - Fork 166
LG-15064: Countdown alerts for expiring phone OTP announces too frequently #11899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
cfb0a6d
add update interval to info on otp expirateion screen
jmdembe bb0c9ac
add class and value for screen reader frequency
jmdembe e704197
remove update frequency
jmdembe ee4abb0
use store value instead of hardcoded number
jmdembe 3b17adf
update documentation and test setup
jmdembe 566a04b
add test for new class
jmdembe 2ddb808
first round of lintfixes for tests
jmdembe b78cb27
udo changes
jmdembe c0c0bcc
trying with the countdown component in screen reader container
jmdembe 3ffc187
clean up syntax
jmdembe ad641ae
change start immediately
jmdembe 06a9f5c
WIP: lintfix and creating untested modal
jmdembe fd12c11
clean up readme file
jmdembe a49d509
more changes to alerts
jmdembe 49dc930
positive step: turn `aria-live` to off when alert appears so that we …
jmdembe c11b920
lintfix: remove console.log
jmdembe 04e4323
remove more `screenReaderFrequency`, try putting an attribute to dela…
jmdembe 17ae171
lintfixes
jmdembe e535937
add class to denote delay?
jmdembe e9bf0d2
add class to denote delay?
jmdembe fa8b30f
Merge branch 'jd/LG-15064-countdown-timer' of github.com:18F/identity…
jmdembe 9533be7
remove `tag_options` because that did not work
jmdembe 6b6e1d1
remove `delay_countdown_announcement`, change `<p>` to '<div>' tags
jmdembe a5a61b4
add new class, function with comment on where to go next
jmdembe bf2c0c8
remove added classes again, make change to countdown element
jmdembe ac114ec
lintfix
jmdembe 2087cc6
add modifier to time so that screenreader time and visible time are s…
jmdembe 51a607e
make update to try and get `show_at_remaining` to sync with visible b…
jmdembe db97b5a
rename configuration and `console.log`
jmdembe ec3dda9
remove config because it does not need to be hard coded
jmdembe f9a9c46
a11y test fix
jmdembe d261989
address code review comments
jmdembe 64f1126
address unused helper and `>` in html
jmdembe aea01dd
Update app/components/countdown_component.rb
jmdembe b17418f
test to show that can be overriden
jmdembe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to include some test coverage for this change, specifically that it's possible to override the default
rolewith another value.