Update dependencies to resolve security advisories#11896
Merged
Conversation
mitchellhenke
approved these changes
Feb 19, 2025
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
aduth
force-pushed
the
aduth-nokogiri-mocha-security
branch
from
9bc0c67 to
3e3af24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
nokogiriRuby gem andmochaNPM package to resolve a pair of security advisories:These don't surface currently in
make audit, likely because thebundler-auditdata source lags behind, and because the NPM package is a development dependency, which does not trigger build failures.Updating Mocha wasn't strictly required, but brings us up to date, since we were a major version behind. The only documented breaking change is a bump in required Node.js version (see changelog).
📜 Testing Plan
Verify
make auditpasses, to ensure no lingering security advisories.Verify
yarn testpasses, to ensure that Mocha major version upgrade does not yield any existing backwards incompatibilities.