Merged
Conversation
jmax-gsa
approved these changes
Feb 19, 2025
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
Mostly looks nice. I added one concrete suggestion about the error messaging. Approving; take or leave the suggestion.
(Also, the hordes of parallel if-elsif-elsifs and switch statements for our different kinds of errors really want to be an error class of some sort, but today is not that day.)
LGTM
Contributor
There was a problem hiding this comment.
For network errors with no additional information available, we just say network: true. Do we want to follow the same pattern here, and say unaccepted_id_type: true? (If we have more information, of course, we could say something like {unaccepted_id_type: 'library_card'}, but I don't think we do here.)
changelog: Bug Fixes, Document Authentication, Validate DocV state ID type
amirbey
force-pushed
the
amirbey/LG-15779-docv-id-type
branch
from
d902185 to
df774c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15779
🛠 Summary of changes
Check the document type received in the verification data to confirm either a license or state ID was authenticated. If not, send the user to the unaccepted ID type error page.
📜 Testing Plan
👀 Screenshots