Merged
Conversation
Sgtpluck
force-pushed
the
dmm/sign-hash
branch
from
3a58052 to
b714dc7
Compare
mitchellhenke
approved these changes
Feb 25, 2025
| ) | ||
| end | ||
|
|
||
| def valid_request_token? |
Contributor
There was a problem hiding this comment.
Just for my own reference/note-taking, this is based on some of the previous implementation here
Contributor
Author
There was a problem hiding this comment.
yes, apologies!
the big difference is we are hashing the token before saving it as config, so we don't have it stored in plaintext anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
Validate signed request
🛠 Summary of changes